This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Rework dash-renderer setProps#478
Merged
Marc-Andre-Rivet merged 31 commits intomasterfrom Mar 11, 2019
Merged
Conversation
added 17 commits
February 27, 2019 15:36
…0rc1 # Conflicts: # dev-requirements.txt
…0rc1 # Conflicts: # dash_core_components/package.json # dash_core_components/version.py # dev-requirements.txt # package.json
3 tasks
Marc-Andre-Rivet
commented
Mar 5, 2019
| "prettier": "^1.14.2", | ||
| "react": "^16.6.1", | ||
| "react-dom": "^16.6.1", | ||
| "react-dot-fragment": "^0.2.8", |
Contributor
Author
There was a problem hiding this comment.
React 16 <Fragment /> polyfill -- gets rid of the wrapper <div /> and allows the same behavior as before -- the extra div could break existing styles or make styling more difficult
Marc-Andre-Rivet
commented
Mar 5, 2019
| if (setProps) { | ||
| setProps(update); | ||
| } | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Like before, inserting onClick prop for the real child to use
Marc-Andre-Rivet
commented
Mar 5, 2019
Marc-Andre-Rivet
changed the title
| test('Tab can be clicked and will display its content', () => { | ||
| tabs.find('[value="tab-2"]').simulate('click'); | ||
| const renderedContent = tabs.find('.tab-content > div').html(); | ||
| const renderedContent = tabs.find(Tab).html(); |
Contributor
Author
There was a problem hiding this comment.
Checking for the Tab component instead of some arbitrary selector
test/unit/Tabs.test.js
Outdated
| test('Tab without value will still be clickable', () => { | ||
| tabs.find('[value="tab-2"]').simulate('click'); | ||
| const renderedContent = tabs.find('.tab-content > div').html(); | ||
| const renderedContent = tabs.find(Tab).html(); |
Contributor
Author
There was a problem hiding this comment.
This test makes no sense. It's the exact copy of the one above with a different name. It's clearly not testing that case.. removing.
| }); | ||
| test('Tab without value will still be clickable', () => { | ||
| tabs.find('[value="tab-2"]').simulate('click'); | ||
| const renderedContent = tabs.find('.tab-content > div').html(); |
Contributor
Author
There was a problem hiding this comment.
This test is an exact copy of the test above. Looks like copy-paste that was never modified. Removing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.