Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

make all dependencies as assets #597

@alexcjohnson

Description

@alexcjohnson

We should be able to treat the plotly.js file as a build artifact, such that upgrading it is as simple as:

  • update the version number in package.json -> devDependencies
  • add a changelog note
  • do NOT commit changes in the dash_core_components dir

Then its build step would consist of:

  • read the version out of node_modules/plotly.js/package.json (don't get it from our own package.json, in case npm i hasn't been called)
  • delete old dash_core_components/plotly-*.js
  • copy node_modules/plotly.js/dist/plotly.min.js into dash_core_components/plotly-<version>.min.js
  • update dash_core_components/__init__.py

Aside from simplifying updates, this would prevent various possible errors, and ensure py/R consistency (plotly.js is already treated as a build artifact as far as the R package is concerned)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions