You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Building the bundle after the dependencies updated from @renovate-bot (#284) was resulting in the following error:
ERROR in ./src/lib/index.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Cannot find module '@babel/core'
babel-loader@8 requires Babel 7.x (the package '@babel/core'). If you'd like to use Babel 6.x ('babel-core'), you should install 'babel-loader@7'.
We can also try to work with the changes Renovate Bot has suggested, instead of fixing the babel-loader package to an outdated version (@mkcor -- would love your thoughts on this, since you've been working the most with the Renovate Bot).
Description of changes
Fix babel-loader version to 7.0.0 so that babel-core can be used.
@shammamah I would much prefer upgrading Babel (https://babeljs.io/docs/en/v7-migration) rather than downgrading babel-loader. Apparently, Babel 7 has been around for over half-a-year (https://babeljs.io/blog/2018/08/27/7.0.0), so I think it would be about time to migrate... Now, if this migration turns out to be very demanding, we can pass in the very short term (and I can approve this PR), but please try first and let me know how much effort you estimate it would require.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the bundle after the dependencies updated from @renovate-bot (#284) was resulting in the following error:
We can also try to work with the changes Renovate Bot has suggested, instead of fixing the
babel-loaderpackage to an outdated version (@mkcor -- would love your thoughts on this, since you've been working the most with the Renovate Bot).Description of changes
babel-loaderversion to7.0.0so that babel-core can be used.Before merging