Skip to content

Fix babel error and update ideogram documentation. #296

Merged
shammamah-zz merged 3 commits intomasterfrom
babel-bundle-fix
Apr 1, 2019
Merged

Fix babel error and update ideogram documentation. #296
shammamah-zz merged 3 commits intomasterfrom
babel-bundle-fix

Conversation

@shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Apr 1, 2019

Building the bundle after the dependencies updated from @renovate-bot (#284) was resulting in the following error:

ERROR in ./src/lib/index.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Cannot find module '@babel/core'
 babel-loader@8 requires Babel 7.x (the package '@babel/core'). If you'd like to use Babel 6.x ('babel-core'), you should install 'babel-loader@7'.

We can also try to work with the changes Renovate Bot has suggested, instead of fixing the babel-loader package to an outdated version (@mkcor -- would love your thoughts on this, since you've been working the most with the Renovate Bot).

Description of changes

  • Fix babel-loader version to 7.0.0 so that babel-core can be used.
  • Generate new version of Ideogram with the updated docstrings from Update ideogram tests. #280

Before merging

@shammamah-zz shammamah-zz requested a review from mkcor April 1, 2019 15:17
@shammamah-zz shammamah-zz temporarily deployed to dash-bio-test-pr-296 April 1, 2019 15:17 Inactive
@mkcor
Copy link
Contributor

mkcor commented Apr 1, 2019

Good catch on updating the Ideogram Python class and metadata! Proof that I didn't rebuild the dash_bio package...

@mkcor
Copy link
Contributor

mkcor commented Apr 1, 2019

@shammamah I would much prefer upgrading Babel (https://babeljs.io/docs/en/v7-migration) rather than downgrading babel-loader. Apparently, Babel 7 has been around for over half-a-year (https://babeljs.io/blog/2018/08/27/7.0.0), so I think it would be about time to migrate... Now, if this migration turns out to be very demanding, we can pass in the very short term (and I can approve this PR), but please try first and let me know how much effort you estimate it would require.

@shammamah-zz
Copy link
Contributor Author

Fixed the babel presets and the dev dependencies as per the instructions here: babel/babel#6808 (comment)

@shammamah-zz shammamah-zz merged commit bb263b1 into master Apr 1, 2019
@mkcor
Copy link
Contributor

mkcor commented Apr 1, 2019

Fixed the babel presets and the dev dependencies as per the instructions here: babel/babel#6808 (comment)

Yay! Great job, @shammamah 👍

@shammamah-zz shammamah-zz deleted the babel-bundle-fix branch April 1, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants