Skip to content

Conversation

@scala-steward
Copy link
Contributor

Updates org.scala-lang.modules:scala-parser-combinators from 1.1.2 to 2.0.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (1.1.2).
You might want to review and update them manually.

src/main/scala/com/typesafe/play/cachecontrol/CurrentAgeCalculator.scala
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-parser-combinators" } ]

labels: library-update, semver-major, old-version-remains

@SethTisue SethTisue merged commit 3701661 into playframework:main Jun 7, 2021
@mkurz
Copy link
Member

mkurz commented Jan 3, 2022

Upgrading scala-parser-combinators to 2.x for Scala versions <3.0 will very likely break libs/apps that use sbt 1.5+, because most other libraries that use Scala 2.12/2.13 are still using v1.x, so sbt will report version conflict errors. I do experience these problems in playframework/playframework#11081 (testing on my machine).

I will make the version conditional, based on the Scala version and cut a new cachecontrol release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants