[bug] pkgm doesn’t create symbolic links using major version numbers breaking libs

[andrewcrook]

Hi

Using curl I noticed that the pkgm installed curl wasn’t working it gave an error message indicating that the openssl library could not be found.

PKGM

>  curl -Ssf https://pkgxdev.github.io/mash/
dyld[7009]: Library not loaded: @rpath/openssl.org/v1/lib/libssl.dylib
  Referenced from: <EA6AA020-36E8-3F24-A7DA-2FFCFA5DFD4E> /usr/local/pkgs/curl.se/v8.12.1/bin/curl
  Reason: tried: '/usr/local/pkgs/curl.se/v8.12.1/bin/../../../openssl.org/v1/lib/libssl.dylib' (no such file), '/usr/local/pkgs/curl.se/v8.12.1/bin/../../../openssl.org/v1/lib/libssl.dylib' (no such file)
zsh: abort      curl -Ssf https://pkgxdev.github.io/mash/

I noticed that the directory of the missing library /openssl.org/v1/lib/libssl.dylib in the message has v1.
Under pkgx I noticed that ‘v1' existed as a symbolic link to ‘v1.1.1w’.

Looking at pkgm’s package directory '/usr/local/pkgs/openssl.org/' I noticed that only ‘v1.1.1w’. existed.

So I created a symbolic link from v1.1.1w to v1

sudo ln -s v1.1.1w v1

This solved the issue

> curl -Ssf https://pkgxdev.github.io/mash/
{
  "scripts": [
    {
      "fullname": "muhil28/magic”, 
# .......... REST OF RESULT

I think pkgm should have created these e.g v1 and v1.1 ?
Would that be covered in pkgm or the calls to pkgx?

I also saw symbolic links to individual files in '/usr/local/lib’ when are these used?

lrwxr-xr-x - root   18 Feb 13:13 libcurl.la -> /usr/local/pkgs/curl.se/v8.12.1/lib/libcurl.la
lrwxr-xr-x - root   18 Feb 13:26 libssl.1.1.dylib -> /usr/local/pkgs/openssl.org/v1.1.1w/lib/libssl.1.1.dylib
lrwxr-xr-x - root   18 Feb 13:26 libssl.a -> /usr/local/pkgs/openssl.org/v1.1.1w/lib/libssl.a
lrwxr-xr-x - root   18 Feb 13:26 libssl.dylib -> /usr/local/pkgs/openssl.org/v1.1.1w/lib/libssl.dylib

[jhheider]

yes, it should definitely be doing this. the links in /usr/local/lib would be used if you built something against it (since they'd only know this canonical path).

[andrewcrook]

in the current readme I saw

Intricacies

1. Packages are installed via pkgx to ~/.pkgx
2. We then sudo hard-link them to /usr/local/pkgs
3. We then symlink the hard-links to /usr/local

should it be creating symbolic links between '~/.pkgx’ and '/usr/local/pkgs’ or has this requirment changed since?
I don't believe it’s currently doing this.

[jhheider]

it says hard links. so, no, not symlinks. hard links, if you're not well-versed, are second filesystem entries that point to the same inode on disk. so they look like regular files (and are, really) in all respects.

[andrewcrook]

oh got you, yeah I normally don't use them.

[andrewcrook]

I have found the issue

it would seem semver.parse cannot parse 1.1.1w I presume it’s the w is causing issue

I wonder if we should start looking at the formatting of versioning for the pantry packages and build a wrapper around ‘semver' to deal with the outliners or just write a replacement function based on str.spilt(‘.’)

[andrewcrook]

Hi I have fixed the issue. I don't use Typescript so had to pull on my experience of other languages I hope what I produced is okay?

[mxcl]

My bad, should have used libpkgx semver. No clue why I didn’t.