feat(usePantry): Add support for multiple dists in distributable.
#214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I added a fixture and it appears to fail, I guess we need to wrap the new fetch code. |
Contributor
Author
It checks and tries to find the first working URL. For invalid URLs, it's supposed to fail. |
Contributor
Author
|
Maybe distributable:
- url: https://downloads.sourceforge.net/project/cscope/cscope/v{{version.raw}}/cscope-{{version.raw}}.tar.gz
strip-components: 1
- url: https://downloads.sourceforge.net/project/cscope/cscope/v{{version.raw}}/cscope-{{version.raw}}.tar.bz2
strip-components: 1 |
Contributor
Author
|
Okay, I misunderstood the fixture. I've added a |
Contributor
Author
|
And thus it passes that test. Sorry for the delay |
Member
|
Tremendous, thanks for the work. |
mxcl
added a commit
that referenced
this pull request
Dec 13, 2023
…214) * redo of #196 * typo * Add a fixture for multiple distributables * fix --------- Co-authored-by: Max Howell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as #196