Fix key_prefix issue with stats and cache_memlimit #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
reviewed
Oct 13, 2022
Collaborator
jparise
left a comment
jparise
left a comment
There was a problem hiding this comment.
Rather than adding a Boolean flag, I wonder if the code would be nicer if we just passed the prefix (or lack of one) as an explicit argument to these functions that need it.
Add integration tests to reproduce the issue and add an argument to _fetch_cmd to skip the key prefix logic as needed. Closes pinterest#430
jparise
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests to reproduce the issue and add an argument to _fetch_cmd to skip the key prefix logic as needed.
Closes #430