Return default from hash client #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `HashClient` with `ignore_exc`, `get` would always return `None` if no server is available. The other clients return the default value in this case. Return the default value so `HashClient` behaves like the other clients. Fixes a variation of issue pinterest#350
jogo
approved these changes
Oct 4, 2021
Pankrat
added a commit
to Pankrat/pymemcache
that referenced
this pull request
Oct 5, 2021
jparise
pushed a commit
that referenced
this pull request
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
HashClientwithignore_exc,getwould always returnNoneif no server is available. The other clients return the defaultvalue in this case.
Return the default value so
HashClientbehaves like the otherclients.
Fixes a variation of issue #350