-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[#noissue] Handle ByteString annotation values of protobuf #9705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9705 +/- ##
============================================
+ Coverage 38.75% 38.84% +0.09%
+ Complexity 11918 11901 -17
============================================
Files 3510 3538 +28
Lines 94258 93975 -283
Branches 10591 10494 -97
============================================
- Hits 36529 36507 -22
+ Misses 54553 54293 -260
+ Partials 3176 3175 -1
|
|
I found we already have |
|
Yup, as @emeroad already pointed it out on last weekly meeting, I will move relating-logic to the location you've suggested. and I guess this PR won't be merged until 2.6.0 release when the actual use of the type |
|
I didn't catch that conversation was about this XD Anyway, the milestone labels are maybe just for some summarizing stuffs like release note, and pointing out the features related to those commits are experimental. I think it is totally fine to merge some branches now, and do some experiments on the dev cluster |
|
Oh, I see. Thank you for the guideline. I will fix it right away then! |
|
Sorry for misguiding. Setting milestone means the PR requires to be merged after the version exactly as you said. |
Since
bytesin protobuf model corresponds tocom.google.protobuf.ByteStringinstead ofbyte[]in Java, I've added logic to convertByteStringtobyte[]whenByteString-typed annotation value is received.