Skip to content

feat: Add Kiro editor support to open picker#1974

Open
ashvinnihalani wants to merge 1 commit intopingdotgg:mainfrom
ashvinnihalani:t3code/kiro-ghost-logo-fix
Open

feat: Add Kiro editor support to open picker#1974
ashvinnihalani wants to merge 1 commit intopingdotgg:mainfrom
ashvinnihalani:t3code/kiro-ghost-logo-fix

Conversation

@ashvinnihalani
Copy link
Copy Markdown
Contributor

@ashvinnihalani ashvinnihalani commented Apr 13, 2026

What Changed

  • add Kiro to shared editor definitions and launch args
  • surface Kiro in the web picker with icon
  • cover command resolution and picker flow with tests

Why

Kiro is enterprise editor that has wide-spread adoption across the industry

UI Changes

Add the Kiro UI icon the the open drop down

Checklist

  • This PR is small and focused
  • [ X] I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk: adds a new editor option and a small arg-composition helper, with tests covering the new launch/selection paths.

Overview
Adds Kiro as a supported editor across contracts, server launch resolution, and the web “Open” picker.

The server now supports editor definitions with optional baseArgs and composes them into launch arguments (so Kiro runs as kiro ide ..., including --goto when applicable), and editor discovery/tests are updated to include Kiro on Windows PATH scans.

The web UI surfaces Kiro in the picker with a new KiroIcon, and a browser test asserts the menu item appears and triggers the expected shellOpenInEditor request.

Reviewed by Cursor Bugbot for commit 184953a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Kiro editor support to the open picker

Macroscope summarized 184953a.

- add Kiro to shared editor definitions and launch args
- surface Kiro in the web picker with icon
- cover command resolution and picker flow with tests
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 298eee16-1077-4aa0-8e3c-7a8bff4074eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ashvinnihalani
Copy link
Copy Markdown
Contributor Author

Screenshot 2026-04-12 at 9 34 30 PM

@github-actions github-actions bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Apr 13, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 13, 2026

Approvability

Verdict: Approved

Straightforward addition of a new editor (Kiro) to the existing open picker, following established patterns used by other editors. The changes are additive with comprehensive test coverage and no impact on existing behavior.

You can customize Macroscope's approvability policy. Learn more.

Comment on lines +82 to +83
const baseArgs = "baseArgs" in editor ? editor.baseArgs : undefined;
return [...(baseArgs ?? []), ...resolveCommandEditorArgs(editor, target)];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const baseArgs = "baseArgs" in editor ? editor.baseArgs : undefined;
return [...(baseArgs ?? []), ...resolveCommandEditorArgs(editor, target)];
const baseArgs = "baseArgs" in editor ? editor.baseArgs : [];
return [...baseArgs, ...resolveCommandEditorArgs(editor, target)];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants