Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Fix format in TOC#851

Merged
ti-chi-bot merged 1 commit intomasterfrom
Fix-format-in-TOC
Dec 7, 2021
Merged

Fix format in TOC#851
ti-chi-bot merged 1 commit intomasterfrom
Fix-format-in-TOC

Conversation

@shichun-0415
Copy link
Contributor

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Fix format in TOC

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 7, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2021
@shichun-0415 shichun-0415 requested review from hfxsd and lilin90 December 7, 2021 08:38
@shichun-0415 shichun-0415 added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format. labels Dec 7, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 7, 2021
Copy link
Contributor

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2021
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2021
@hfxsd
Copy link
Contributor

hfxsd commented Dec 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d0868c0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2021
@ti-chi-bot ti-chi-bot merged commit ed1ac3e into master Dec 7, 2021
@lilin90 lilin90 deleted the Fix-format-in-TOC branch December 7, 2021 09:56
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 7, 2021
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #852.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #853.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 7, 2021
9 tasks
ti-chi-bot added a commit that referenced this pull request Dec 7, 2021
ti-chi-bot added a commit that referenced this pull request Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants