Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

best practice in using bigint data type#68

Open
knull-cn wants to merge 3 commits intopingcap:masterfrom
knull-cn:dev
Open

best practice in using bigint data type#68
knull-cn wants to merge 3 commits intopingcap:masterfrom
knull-cn:dev

Conversation

@knull-cn
Copy link

@knull-cn knull-cn commented Jan 10, 2022 •
edited by jackysp
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • add description : best practice in using bigint data type

Which TiDB version(s) do your changes apply to? (Required)

all tidb version which is suport binary type

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status size/L labels Jan 10, 2022
@knull-cn knull-cn force-pushed the dev branch 4 times, most recently from 361fba7 to 8963a83 Compare January 11, 2022 09:45
@jinwhu
Copy link
Contributor

jinwhu commented Jan 12, 2022

LGTM

jackysp
jackysp reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jackysp jackysp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to hide blockchain in this article, because it is illegal in some countries.

@jackysp jackysp changed the title best practice in using bigint data type for blockchain industry best practice in using bigint data type Jan 12, 2022
jackysp
jackysp reviewed Jan 14, 2022
View reviewed changes
zh/_index.md Outdated
- [分页的最佳实践](tidb-database-development-specification/best-practices-for-paging.md)
- [唯一序列号生成方案](tidb-database-development-specification/unique-serial-number-generation-scheme.md)
- [流程规范](tidb-database-development-specification/process-specification.md)
- [TiDB 大整数最佳实践](tidb-database-development-specification/best-practice-in-using-bigint-data-type.md)
Copy link
Contributor

@jackysp jackysp Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not need TiDB in the index.

Copy link
Author

@knull-cn knull-cn Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use database instead tidb or delete it ?

jackysp
jackysp reviewed Jan 14, 2022
View reviewed changes
zh/tidb-database-development-specification/best-practice-in-using-bigint-data-type.md
@@ -0,0 +1,106 @@
---
title: TiDB 大整数最佳实践
Copy link
Contributor

@jackysp jackysp Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not need TiDB in the title.

jackysp
jackysp reviewed Jan 14, 2022
View reviewed changes
zh/tidb-database-development-specification/best-practice-in-using-bigint-data-type.md Outdated
@@ -0,0 +1,106 @@
---
title: TiDB 大整数最佳实践
summary: 介绍 大整数 在 TiDB 中的应用
Copy link
Contributor

@jackysp jackysp Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why added space around 大整数?

Copy link
Author

@knull-cn knull-cn Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will delete the space

jackysp
jackysp reviewed Jan 14, 2022
View reviewed changes
zh/tidb-database-development-specification/best-practice-in-using-bigint-data-type.md Outdated
summary: 介绍 大整数 在 TiDB 中的应用
---

# TiDB 大整数最佳实践
Copy link
Contributor

@jackysp jackysp Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

jackysp
jackysp reviewed Jan 14, 2022
View reviewed changes
zh/tidb-database-development-specification/best-practice-in-using-bigint-data-type.md Outdated
Comment on lines +10 to +12
现在大部分程序语言直接支持 64 bit 的内置类型，即直接支持相关运算。而 `大整数` 是超过 64 bit 的整数，一般是需要自己来实现。

有些场景，`大整数`是必需品(比如 **区块链** 应用，大整数是基础)。我们 TiDB 客户也有大整数的需求，这里根据几个成功案例，总结大整数的解决方案。
Copy link
Contributor

@jackysp jackysp Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too colloquial.

Copy link
Author

@knull-cn knull-cn Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

jackysp
jackysp reviewed Jan 14, 2022
View reviewed changes
zh/tidb-database-development-specification/best-practice-in-using-bigint-data-type.md Outdated

### 2. 字节序(Byte Order)

字节序，大家应该都有了解。或者，网上资料、说明一大坨，自己看吧。
Copy link
Contributor

@jackysp jackysp Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too colloquial.

Copy link
Author

@knull-cn knull-cn Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got

jackysp
jackysp reviewed Jan 14, 2022
View reviewed changes
Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to add these to a new section, for example called Best Practices.

@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jackysp jackysp jackysp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@knull-cn @ti-chi-bot @jinwhu @jackysp