Skip to content

Conversation

@shmax
Copy link
Contributor

@shmax shmax commented Sep 24, 2023

More coverage twiddling.

For this one, I also rejiggered Validations a bit so that it does a bit less reflection work. I have no idea if it will affect performance, but it reduces complexity.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #97 (c600650) into master (3bfe5e5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #97      +/-   ##
============================================
+ Coverage     98.77%   98.81%   +0.04%     
+ Complexity      954      953       -1     
============================================
  Files            34       34              
  Lines          2366     2362       -4     
============================================
- Hits           2337     2334       -3     
+ Misses           29       28       -1     
Files Changed Coverage Δ
lib/Validations.php 96.27% <100.00%> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shmax shmax merged commit 6a68bcf into master Sep 24, 2023
@shmax shmax deleted the improve-coverage branch September 24, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants