fix of crash when Note class could not be serialized#4
Open
AndrzejPw wants to merge 1 commit intophilipplackner:masterfrom
Open
fix of crash when Note class could not be serialized#4AndrzejPw wants to merge 1 commit intophilipplackner:masterfrom
AndrzejPw wants to merge 1 commit intophilipplackner:masterfrom
Conversation
list is persisted in db anyway so this is not needed
Author
|
@philipplackner could you look at this? Btw. great work, I'm learning from you everyday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crash was mentioned here
boilerplate but could not just add Parcelable annotation to Note class because it is contained in pure Kotlin module :(
UPDATE:
sorry, I changed approach, I think SavedStateHandler is not needed on list because all notes are persisted in DB anyway.
On details it's useful because it can save user input which was not persisted in db yet.