Tests: Improve test DX #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
test-dx
branch
3 times, most recently
from
719f7fc to
5308dff
Compare
dantleech
commented
Oct 29, 2025
| $testProviderArray[basename($testCase)] = [$testCase, $testCase . ".tree", $testCase . ".diag"]; | ||
| } | ||
| foreach (self::PATTERNS_FOR_MINIMUM_PHP_VERSION as [$minVersionId, $filePattern]) { | ||
| if (PHP_VERSION_ID < $minVersionId) { |
Collaborator
Author
There was a problem hiding this comment.
just a refactor for having an early continue
dantleech
commented
Oct 29, 2025
- Generate snapshot if file does not exist rather than whatever it was doing before. - Upgrade phpunit - Removed CallbackTestListener - Add hint about regeneration in assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure what the benefit of the original "git" approach was. This PR essentially simplifies things by generating the snapshot (expected output) if it doesn't exist.
Note: apart from anything else overriding PHPUnit's
TestCase#runis no longer allowed as it's final.