-
Notifications
You must be signed in to change notification settings - Fork 58
Allowing log_level to be set during instantiation of RequestProxy (#68) #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @broglea thanks for the PR -- pretty useful change indeed!
Could you also add some kind of documentation for future reference?
RequestProxy init would be one place to doc the parameters, and the API example could show how to use it. https://github.com/pgaref/HTTP_Request_Randomizer#api
Btw, this could also be a super useful option as part of the command line interface -- but could, of course, be a follow-up. https://github.com/pgaref/HTTP_Request_Randomizer#command-line-interface
|
@pgaref I added documentation of this to my branch. Should I also bump the version here in this PR so a new release can be cut with this change? |
|
I am actually unsure how to properly bump version as in |
Lets bump that to 1.3.2 and I can take care of the release. Just make sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add a Logging level as part of the example :)
https://github.com/pgaref/HTTP_Request_Randomizer/pull/67/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R102
|
@pgaref done and done |
pgaref
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merged to master, @broglea thanks again for the PR! I am going to release this as 1.3.2 asap |
There is no current way to stop this from logging to the console with the way this was hard coded to log everything. You can't override the logging level of this module from a calling module because this overrides it whenever you instantiate a new instance of the class and things are logged during the
__init__of the object.This allows the person using this library to pass in an optional log level.