Open
Conversation
MarkCuypersPpw
approved these changes
Feb 27, 2026
glenstaes
reviewed
Feb 27, 2026
projects/ppwcode/ng-dialogs/src/lib/confirmation-dialog/confirmation-dialog.component.ts
Outdated
Show resolved
Hide resolved
glenstaes
reviewed
Feb 27, 2026
|
|
||
| async function createComponent(data: Partial<ConfirmationDialogData> = {}) { | ||
| await TestBed.configureTestingModule({ | ||
| imports: [ConfirmationDialogComponent, MatDialogModule, MatButtonModule, NoopAnimationsModule], |
Member
There was a problem hiding this comment.
Use the provideNoopAnimations standalone provider instead of the NoopAnimationsModule import.
glenstaes
reviewed
Feb 27, 2026
| } | ||
| ] | ||
| }) | ||
| }).compileComponents() |
Member
There was a problem hiding this comment.
Normally the .compileComponents should not be necessary, only when running the test outside of Angular compilation (which is not applicable here because we run ng test).
This avoids having to await this call and having to make createComponent async and therefore also the unit tests async.
Member
There was a problem hiding this comment.
There's still async and await keywords that can be removed :)
glenstaes
requested changes
Feb 27, 2026
glenstaes
requested changes
Feb 27, 2026
maaso
force-pushed
the
feature/confirmation-dialog-options
branch
from
b6000e4 to
2ed78d6
Compare
added 2 commits
February 27, 2026 17:25
…type, color in confirmation dialog
maaso
force-pushed
the
feature/confirmation-dialog-options
branch
from
2ed78d6 to
8629bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added button & icon configuration options to ConfirmationDialog