Conversation
Contributor
|
Please don't mark your pull request as in-progress unless you do -not- want it merged. The normal usage for draft/work-in-progress is when you need commentary on it. There's nothing to discuss on these types of PRs. |
Contributor
|
@coco3427 I think some of the other changes that have gone in have conflicted with your changes. I think this PR should be updated (resolve the conflicts) and then ask Jan to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds space before progress bar for #644
Description
I added a extra space before the progress bar in the same manner as @wrigjl for all sections in ch9, ch5 still needs to be done.
I cant see the task bar on my local host, because i don't have the full Runestone environment, but i think its correct.
How Has This Been Tested?
I cant see the task bar on my local host, because i don't have the full Runestone environment, but i think its correct.