Restructure filesystem to better align concerns and support upgrades#280
Merged
bmuenzenmeyer merged 5 commits intodevfrom Mar 7, 2016
Merged
Restructure filesystem to better align concerns and support upgrades#280bmuenzenmeyer merged 5 commits intodevfrom
bmuenzenmeyer merged 5 commits intodevfrom
Conversation
passing unit tests and building frontend #133
move source/_patternlab-files/pattern-header-footer to core/source/_meta updated config entries #133
Contributor
|
YES |
Member
Author
|
I was initially going to put the shipped patterns into core/source and then build a mechanism to move them over into config.source.* path, but I don't really see a big benefit aside from having a clean copy if a user wanted it. Need to think about it more. Thinking through to the eventual inclusion of starter kits, seems easier to deviate from this PHP pattern |
bmuenzenmeyer
pushed a commit
that referenced
this pull request
Mar 7, 2016
Restructure filesystem to better align concerns and support upgrades
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #133
Summary of changes:
move source/eveythingelseish to core/source ?????"Open in new window" should be a page with no PL JS #265moving off this PR