refactor: optimized engines directory retrieval #1359#1364
Merged
JosefBredereck merged 6 commits intopattern-lab:devfrom Nov 3, 2021
Merged
Conversation
especially for npm workspaces usage (aka npm 7 monorepos)
especially for development in the PL codebase itself
JosefBredereck
approved these changes
Nov 3, 2021
Contributor
JosefBredereck
left a comment
JosefBredereck
left a comment
There was a problem hiding this comment.
Tested locally and deployment on netlify works too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1347
Summary of changes:
The logic for resolving the path to engines directories has been implemented long before
npm workspacesgot introduced (actually with commit 416132c in mid 2016), so we would need to refactor this implementation.