Skip to content

refactor(docs): optimizations #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosefBredereck merged 5 commits into from
Jun 11, 2021
Merged

refactor(docs): optimizations #1327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c41e1e4
refactor(docs): added dimensions to the images
mfranzke May 23, 2021
54c1ea6
refactor(yarn): removed unnecessary additional -- for parameters
mfranzke May 23, 2021
055cc02
fix(docs): corrected the path for a copy action
mfranzke May 23, 2021
100f970
chore(docs): added nunjucks dependency
mfranzke May 24, 2021
ec91dd8
Merge branch 'dev' into refactor-docs-optimizations
mfranzke Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docs/.eleventy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module.exports = function (config) {
config.addPassthroughCopy('src/js');
config.addPassthroughCopy('src/admin/config.yml');
config.addPassthroughCopy('src/admin/previews.js');
config.addPassthroughCopy('node_modules/nunjucks/browser/nunjucks-slim.js');
config.addPassthroughCopy('../../node_modules/nunjucks/browser/nunjucks-slim.js');

const now = new Date();

Expand Down
3 changes: 2 additions & 1 deletion packages/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"concurrently": "^4.1.0",
"html-minifier": "^4.0.0",
"json-to-scss": "^1.6.2",
"nunjucks": "^3.2.3",
"sass": "^1.32.8",
"semver": "^6.3.0",
"slugify": "^1.5.0",
Expand All @@ -34,7 +35,7 @@
"sass:process": "yarn sass:tokens && sass src/scss/style.scss dist/css/style.css --style=compressed",
"cms:precompile": "make-dir dist/admin && nunjucks-precompile src/_includes > dist/admin/templates.js -i \"\\.(njk|css|svg)$\"",
"cms:bundle": "rollup --config",
"start": "concurrently \"yarn sass:process -- --watch\" \"yarn cms:bundle -- --watch\" \"chokidar \\\"src/_includes/**\\\" -c \\\"yarn cms:precompile\\\"\" \"yarn serve\"",
"start": "concurrently \"yarn sass:process --watch\" \"yarn cms:bundle --watch\" \"chokidar \\\"src/_includes/**\\\" -c \\\"yarn cms:precompile\\\"\" \"yarn serve\"",
"serve": "cross-env ELEVENTY_ENV=development npx eleventy --serve",
"production": "yarn sass:process && yarn cms:precompile && yarn cms:bundle && npx eleventy"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/docs/src/_includes/components/logo.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@

<h3 class="c-logo">
<a href="/" class="c-logo__link" rel="home">
<img class="c-logo__img" src="https://patternlab.io/images/icon-atom.svg" alt="Pattern Lab logo" aria-hidden="true">
<img class="c-logo__img" src="https://patternlab.io/images/icon-atom.svg" alt="Pattern Lab logo" aria-hidden="true" width="38" height="36">

<div class="c-logo__body">
<div class="c-logo__body">
<span class="c-logo__text">Pattern Lab</span>
</div>
</a>
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/src/docs/advanced-ecosystem-overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Editions let teams and agencies bundle all the things that support their unique

The following is good overview of what components might make up an edition:

<img src="/images/pattern-lab-2-image_18-large-opt.png">
<img src="/images/pattern-lab-2-image_18-large-opt.png" width="640" height="509" alt="Pattern Lab Edition">

This is by no means exhaustive and can be added to as needed. Here is a description of each component:

Expand Down