refactor(logging): aligned error messages with reporting criticality#1317
Merged
JosefBredereck merged 3 commits intopattern-lab:devfrom May 17, 2021
Merged
Conversation
If we call it an error in the message, we should even also mark it as an error instead of an info or a warning
so we'll use a warning here
JosefBredereck
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1315
Summary of changes:
If we call it an error in the logging message, we should even also mark it as an
errorinstead of aninfoor awarning. This is as well related to console output depending on the log level setting within the configuration.The changes on lines 67 and 75 within the file
packages/plugin-tab/src/tab-loader.jsare unrelated to the contents of this change request, but most likely triggered by automatic prettifying throughprettier/pretty-quickbyhuskygit commits.