refactor(eslint): integrated feedback#1304
Merged
JosefBredereck merged 2 commits intopattern-lab:devfrom Mar 23, 2021
Merged
Conversation
out of auto-fixable stuff
most likely out of beautification
JosefBredereck
requested review from
JosefBredereck
and removed request for
sghoweri
JosefBredereck
approved these changes
Mar 23, 2021
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor(eslint): integrated feedback out of auto-fixable stuff * refactor(eslint): integrated feedback most likely out of beautification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Integrated some code changes that were in included within the feedback by eslint test