fix(demopage): switched to HTTPS URLs for image placeholders#1289
Merged
JosefBredereck merged 2 commits intopattern-lab:devfrom Feb 19, 2021
Merged
Conversation
JosefBredereck
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1288
Summary of changes:
Switched from HTTP to HTTPS URLs for the image placeholders by the online service via.placeholder.com.
In case of the page being served via HTTPS (like https://patternlab-handlebars-preview.netlify.app/) you'll elsewhere get browsers warnings and errors of any kind. In the unlikely case that the demo pages would get served via HTTP, there's no downside of these references to HTTPS instead.