fix: Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours by vivekjoshi556 · Pull Request #9113 · parse-community/parse-server

vivekjoshi556 · 2024-05-01T04:51:06Z

Pull Request

This PR helps with dynamically extending session based on session Length.

Issue

Closes: #8981

Approach

I followed a similar approach to what @mman suggested here.

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)

parse-github-assistant · 2024-05-01T04:51:09Z

Thanks for opening this pull request!

vivekjoshi556 · 2024-05-01T04:54:19Z

Hello @mman,
You mentioned that you would beta test. Please look at the solution and let me know what you think.

codecov · 2024-05-01T04:58:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (f1469c6) to head (57f8283).
Report is 13 commits behind head on alpha.

❗ Current head 57f8283 differs from pull request most recent head c99c48b

Please upload reports for the commit c99c48b to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #9113      +/-   ##
==========================================
+ Coverage   94.13%   94.15%   +0.01%     
==========================================
  Files         186      186              
  Lines       14687    14726      +39     
==========================================
+ Hits        13826    13865      +39     
  Misses        861      861

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mman · 2024-05-01T09:38:55Z

Thanks a lot @vivekjoshi556, I will take a look first thing next week, now OOO.

vivekjoshi556 · 2024-05-06T13:33:16Z

Hey @mman. Just wanted to check if you got some time to look at the PR.

mman · 2024-05-06T14:10:55Z

@vivekjoshi556 The code looks nice and clean, the tests as well. Will try to deploy to my stage env later today.

vivekjoshi556 · 2024-05-10T11:50:03Z

Hey @mman Just wanted to check in again.

@mtrezza if you have inputs as well, please let me know.

There is a minor issue with linting I'll fix it in the next push, anything else let me know.

src/Auth.js

spec/Auth.spec.js

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

src/Auth.js

mtrezza · 2024-05-10T13:18:55Z

This fix just shifts the problem downwards from 24 hours to 1 minute. Because for a session length of <1 minute, the problem in #8981 persists.

I wonder whether we need such a complex logic for this. If I understand #8981 (comment) correctly, the purpose of this logic is to find a middle ground between:

extending the session on every request --> con: high DB writes
ensuring that the session extends before it expires --> con: session would never get extended

Wouldn't it be simpler to extend the session when the remaining session token validity time reached < 50% of the session length?

For example:

session length 1 year --> session extends if remaining time is < 182 days
session length 1 day --> session extends if remaining time is < 12 hours
session length 1 hour --> session extends if remaining time is < 30 mins
session length 1 minute --> session extends if remaining time is < 30 secs

Pros:

Simple to document and understand
This adapts dynamically to the session length, instead of some arbitrary extension trigger times
It's easy to make this configurable via a new Parse Server option in the future, by letting a developer configure the threshold, e.g. 50% as in examples above.

And could you please document this new behavior in the Parse Server option extendSessionOnUse?

spec/Auth.spec.js

mtrezza · 2024-05-14T22:51:17Z

@vivekjoshi556 Just a friendly ping here; if you could simplify the logic and add the functionality description to the option docs (this repo, not the docs repo), then we could go ahead and merge.

vivekjoshi556 · 2024-05-15T10:11:00Z

So sorry just got a bit swamped with work. Give me some time

…documentation for shouldUpdateSessionExpiry

vivekjoshi556 · 2024-05-27T03:24:32Z

@mtrezza I have made the mentioned changes. Please let me know if anything else needs to be done.

src/Options/index.js

src/Options/docs.js

src/Options/Definitions.js

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

# [7.1.0-alpha.9](7.1.0-alpha.8...7.1.0-alpha.9) (2024-05-27) ### Bug Fixes * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6))

parseplatformorg · 2024-05-27T14:34:29Z

🎉 This change has been released in version 7.1.0-alpha.9

mman · 2024-05-27T14:47:30Z

@vivekjoshi556 Excellent, very clean code, putting into production :)

# [7.1.0-beta.1](7.0.0...7.1.0-beta.1) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))

parseplatformorg · 2024-06-30T02:03:43Z

🎉 This change has been released in version 7.1.0-beta.1

# [7.1.0](7.0.0...7.1.0) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))

parseplatformorg · 2024-06-30T02:23:56Z

🎉 This change has been released in version 7.1.0

fix: ExtendSessionOnUse Updates

06676cb

mtrezza reviewed May 10, 2024

View reviewed changes

src/Auth.js Outdated Show resolved Hide resolved

mtrezza reviewed May 10, 2024

View reviewed changes

spec/Auth.spec.js Outdated Show resolved Hide resolved

lint and comment

52faf40

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza reviewed May 10, 2024

View reviewed changes

src/Auth.js Show resolved Hide resolved

mtrezza requested changes May 10, 2024

View reviewed changes

spec/Auth.spec.js Outdated Show resolved Hide resolved

mtrezza changed the title ~~fix: ExtendSessionOnUse Updates~~ fix: Parse Server option extendSessionOnUse not working for session lengths < 24 hours May 10, 2024

Merge branch 'alpha' into issue_8981

47eb420

mtrezza and others added 2 commits May 16, 2024 20:16

Merge branch 'alpha' into issue_8981

da99d51

refactor: refactored shouldUpdateSessionExpiry() logic | docs: added …

57f8283

…documentation for shouldUpdateSessionExpiry

mtrezza reviewed May 27, 2024

View reviewed changes

src/Options/index.js Outdated Show resolved Hide resolved

mtrezza reviewed May 27, 2024

View reviewed changes

src/Options/docs.js Outdated Show resolved Hide resolved

mtrezza reviewed May 27, 2024

View reviewed changes

src/Options/Definitions.js Outdated Show resolved Hide resolved

improve docs

c99c48b

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza approved these changes May 27, 2024

View reviewed changes

mtrezza merged commit 0a054e6 into parse-community:alpha May 27, 2024

parseplatformorg added the state:released-alpha Released as alpha version label May 27, 2024

vivekjoshi556 deleted the issue_8981 branch May 27, 2024 15:26

parseplatformorg added the state:released-beta Released as beta version label Jun 30, 2024

parseplatformorg added the state:released Released as stable version label Jun 30, 2024

Uh oh!

Conversation

vivekjoshi556 commented May 1, 2024

Pull Request

Issue

Approach

Tasks

Uh oh!

parse-github-assistant bot commented May 1, 2024

Thanks for opening this pull request!

Uh oh!

vivekjoshi556 commented May 1, 2024

Uh oh!

codecov bot commented May 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mman commented May 1, 2024

Uh oh!

vivekjoshi556 commented May 6, 2024

Uh oh!

mman commented May 6, 2024

Uh oh!

vivekjoshi556 commented May 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtrezza commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mtrezza commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vivekjoshi556 commented May 15, 2024

Uh oh!

vivekjoshi556 commented May 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

parseplatformorg commented May 27, 2024

Uh oh!

mman commented May 27, 2024

Uh oh!

parseplatformorg commented Jun 30, 2024

Uh oh!

parseplatformorg commented Jun 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented May 1, 2024 •

edited

Loading

mtrezza commented May 10, 2024 •

edited

Loading

mtrezza commented May 14, 2024 •

edited

Loading