perf: Improve performance of recursive pointer iterations by chderen · Pull Request #8741 · parse-community/parse-server

chderen · 2023-09-11T12:56:49Z

Pull Request

Code change for performances.

Instead of creating and updating the answer array on each iterations, use map function.

Code change for performances. Instead of creating and updating the answer array on each iterations, use map function. Signed-off-by: Yechezkel Deren <chderen@gmail.com>

parse-github-assistant · 2023-09-11T12:56:52Z

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

mtrezza · 2023-09-11T13:53:01Z

Do you have any proof that this is actually better performing and not worse?

chderen · 2023-09-11T14:21:50Z

I tested on my computer. for arrays grater then 1000 there is a big diff

Signed-off-by: Yechezkel Deren <chderen@gmail.com>

mtrezza · 2023-09-12T09:51:28Z

Could you share the metrics and tool you used for performance measurement? There may be factors in the test set-up that would need to be considered (caching, etc) to know how reliable the test results are.

chderen · 2023-09-12T14:17:12Z

I have isolated the relevant code, and created a test here https://jsbench.me/talmgdggir/1

mtrezza

Thanks for sharing the performance test; looks good. Maybe you can improve the PR title to explain the improvement in more practical terms.

codecov · 2023-09-13T11:56:10Z

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.86% ⚠️

Comparison is base (977edea) 94.32% compared to head (3e65d8a) 87.46%.

❗ Current head 3e65d8a differs from pull request most recent head b596a9d. Consider uploading reports for the commit b596a9d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #8741      +/-   ##
==========================================
- Coverage   94.32%   87.46%   -6.86%     
==========================================
  Files         186      186              
  Lines       14773    14770       -3     
==========================================
- Hits        13935    12919    -1016     
- Misses        838     1851    +1013

Files Changed	Coverage Δ
src/RestQuery.js	`92.79% <100.00%> (-2.91%)`	⬇️

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# [6.3.0-alpha.9](6.3.0-alpha.8...6.3.0-alpha.9) (2023-09-13) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))

parseplatformorg · 2023-09-13T12:18:23Z

🎉 This change has been released in version 6.3.0-alpha.9

# [6.4.0-beta.1](6.3.0...6.4.0-beta.1) (2023-09-16) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))

parseplatformorg · 2023-09-16T02:53:54Z

🎉 This change has been released in version 6.4.0-beta.1

* commit 'b1e1bf6708f5d32b2846e66de40f48fb0ec1dc86': chore(release): 6.4.0-beta.1 [skip ci] release chore(release): 6.3.0 [skip ci] release chore(release): 6.3.0-alpha.9 [skip ci] perf: Improve performance of recursive pointer iterations (parse-community#8741) refactor: Parse Pointer allows to access internal Parse Server classes and circumvent `beforeFind` query trigger (parse-community#8734) chore(release): 6.2.2 [skip ci] fix: Parse Pointer allows to access internal Parse Server classes and circumvent `beforeFind` query trigger; fixes security vulnerability [GHSA-fcv6-fg5r-jm9q](GHSA-fcv6-fg5r-jm9q) refactor: Remote code execution via MongoDB BSON parser through prototype pollution; fixes security vulnerability [GHSA-462x-c3jw-7vr6](GHSA-462x-c3jw-7vr6) (parse-community#8677) chore(release): 6.2.1 [skip ci] fix: Remote code execution via MongoDB BSON parser through prototype pollution; fixes security vulnerability [GHSA-462x-c3jw-7vr6](GHSA-462x-c3jw-7vr6) (parse-community#8674) refactor: Add option to convert `Parse.Object` to instance in Cloud Function payload (parse-community#8656)

# [6.4.0-alpha.1](6.3.0...6.4.0-alpha.1) (2023-09-20) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add context to Cloud Code Triggers `beforeLogin` and `afterLogin` ([#8724](#8724)) ([a9c34ef](a9c34ef)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))

parseplatformorg · 2023-09-20T08:50:23Z

🎉 This change has been released in version 6.4.0-alpha.1

# [6.4.0](6.3.1...6.4.0) (2023-11-16) ### Bug Fixes * Parse Server option `fileUpload.fileExtensions` does not work with an array of extensions ([#8688](#8688)) ([6a4a00c](6a4a00c)) * Redis 4 does not reconnect after unhandled error ([#8706](#8706)) ([2b3d4e5](2b3d4e5)) * Remove config logging when launching Parse Server via CLI ([#8710](#8710)) ([ae68f0c](ae68f0c)) * Server does not start via CLI when `auth` option is set ([#8666](#8666)) ([4e2000b](4e2000b)) ### Features * Add conditional email verification via dynamic Parse Server options `verifyUserEmails`, `sendUserEmailVerification` that now accept functions ([#8425](#8425)) ([44acd6d](44acd6d)) * Add property `Parse.Server.version` to determine current version of Parse Server in Cloud Code ([#8670](#8670)) ([a9d376b](a9d376b)) * Add TOTP authentication adapter ([#8457](#8457)) ([cc079a4](cc079a4)) ### Performance Improvements * Improve performance of recursive pointer iterations ([#8741](#8741)) ([45a3ed0](45a3ed0))

parseplatformorg · 2023-11-16T15:27:54Z

🎉 This change has been released in version 6.4.0

Update RestQuery.js

64fc43c

Code change for performances. Instead of creating and updating the answer array on each iterations, use map function. Signed-off-by: Yechezkel Deren <chderen@gmail.com>

chderen changed the title ~~Update RestQuery.js~~ refactor: Update in RestQuery.js Sep 11, 2023

remove trailing space

b596a9d

Signed-off-by: Yechezkel Deren <chderen@gmail.com>

mtrezza approved these changes Sep 12, 2023

View reviewed changes

mtrezza changed the title ~~refactor: Update in RestQuery.js~~ perf: Imrpove performance of recursive pointer iterations in RestQuery.js Sep 12, 2023

mtrezza changed the title ~~perf: Imrpove performance of recursive pointer iterations in RestQuery.js~~ perf: Improve performance of recursive pointer iterations in RestQuery.js Sep 12, 2023

mtrezza changed the title ~~perf: Improve performance of recursive pointer iterations in RestQuery.js~~ perf: Improve performance of recursive pointer iterations in RestQuery.js Sep 13, 2023

mtrezza changed the title ~~perf: Improve performance of recursive pointer iterations in RestQuery.js~~ perf: Improve performance of recursive pointer iterations Sep 13, 2023

mtrezza merged commit 45a3ed0 into parse-community:alpha Sep 13, 2023

parseplatformorg added the state:released-alpha Released as alpha version label Sep 13, 2023

chderen deleted the patch-1 branch September 13, 2023 12:21

parseplatformorg added the state:released-beta Released as beta version label Sep 16, 2023

parseplatformorg added the state:released Released as stable version label Nov 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf: Improve performance of recursive pointer iterations#8741

perf: Improve performance of recursive pointer iterations#8741
mtrezza merged 2 commits intoparse-community:alphafrom
chderen:patch-1

chderen commented Sep 11, 2023 •

edited

Loading

Uh oh!

parse-github-assistant bot commented Sep 11, 2023 •

edited

Loading

Uh oh!

mtrezza commented Sep 11, 2023 •

edited

Loading

Uh oh!

chderen commented Sep 11, 2023

Uh oh!

mtrezza commented Sep 12, 2023 •

edited

Loading

Uh oh!

chderen commented Sep 12, 2023

Uh oh!

mtrezza left a comment •

edited

Loading

Uh oh!

codecov bot commented Sep 13, 2023

Uh oh!

parseplatformorg commented Sep 13, 2023

Uh oh!

parseplatformorg commented Sep 16, 2023

Uh oh!

parseplatformorg commented Sep 20, 2023

Uh oh!

parseplatformorg commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

chderen commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Uh oh!

parse-github-assistant bot commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

mtrezza commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chderen commented Sep 11, 2023

Uh oh!

mtrezza commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chderen commented Sep 12, 2023

Uh oh!

mtrezza left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 13, 2023

Codecov Report

Uh oh!

parseplatformorg commented Sep 13, 2023

Uh oh!

parseplatformorg commented Sep 16, 2023

Uh oh!

parseplatformorg commented Sep 20, 2023

Uh oh!

parseplatformorg commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chderen commented Sep 11, 2023 •

edited

Loading

parse-github-assistant bot commented Sep 11, 2023 •

edited

Loading

mtrezza commented Sep 11, 2023 •

edited

Loading

mtrezza commented Sep 12, 2023 •

edited

Loading

mtrezza left a comment •

edited

Loading