Fix fileupload defaults not applied#7086
Conversation
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387': fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007) fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009) fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008) fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011) update stale bot (parse-community#6998) fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005) fix(beforeSave): Skip Sanitizing Database results (parse-community#7003) Fix includeAll for querying a Pointer and Pointer array (parse-community#7002) Init (parse-community#6999)
Codecov Report
@@ Coverage Diff @@
## master #7086 +/- ##
==========================================
+ Coverage 93.66% 93.89% +0.23%
==========================================
Files 169 169
Lines 12499 12501 +2
==========================================
+ Hits 11707 11738 +31
+ Misses 792 763 -29
Continue to review full report at Codecov.
|
|
@mtrezza seems to have many change, did you run prettier and lint fix ? |
mtrezza
requested review from
davimacedo and
dplewis
and removed request for
davimacedo and
dplewis
|
@parse-community/server This PR should be reviewed ASAP, it fixes a bug in the current main branch that prevents file upload if default settings are not set. |
Moumouls
left a comment
Moumouls
left a comment
There was a problem hiding this comment.
A lot of changes on spec/ParseFile, does prettier is ok on it ?
| fileUpload: { | ||
| env: 'PARSE_SERVER_FILE_UPLOAD_OPTIONS', | ||
| help: 'Options for file uploads', | ||
| action: parsers.objectParser, | ||
| default: {}, |
There was a problem hiding this comment.
Any way to remove the default empty object ? An empty object can be translated to undefined.
There was a problem hiding this comment.
Why do you want to remove it?
There was a problem hiding this comment.
@Moumouls Do you want to elaborate your concern? Otherwise I’ll merge.
|
@dplewis @davimacedo can you please approve this, so we can merge this? The current master has a bug that does not allow file upload. I am afraid this may be forgotten before a new Parse Server release, so I'd rather see this merged ASAP. |
|
Looks like the Parse.File.spec.js has a lot of changes. @Moumouls Also mentioned this. |
|
Just some describe grouping, hence large diff, see 977e16a |
|
LGTM! |
* added fileUpload definition default value * added undefined and null as invalid * removed explicit default value reference * improved test grouping in describes
* added fileUpload definition default value * added undefined and null as invalid * removed explicit default value reference * improved test grouping in describes
|
🎉 This change has been released in version 5.0.0-beta.1 |
|
🎉 This change has been released in version 5.0.0 |
4 participants
New Pull Request Checklist
Issue Description
Default values of
fileUploadare not applied iffileUploadoption is not set explicitly in the Parse Server config option.Related issue: closes #7085
Approach
Added default definition for
fileUploadgroup parameter.TODOs before merging