Do not pass objectId, updatedAt, createdAt to beforeSave hooks on object create.#587
Merged
Do not pass objectId, updatedAt, createdAt to beforeSave hooks on object create.#587
Conversation
Contributor
|
This is great for backwards compatibility I guess, but I kind of liked the new behavior. Especially with the |
Contributor
Author
|
You still will get |
Contributor
Author
|
Let me expand a little bit more here: |
nlutsenko
added a commit
that referenced
this pull request
Feb 23, 2016
Do not pass objectId, updatedAt, createdAt to beforeSave hooks on object create.
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud Code never passed these on beforeSave, so move them to after beforeSave hooks run to make sure we don't pass them.
This unbreaks
isNew(), since we are not going to haveobjectIdanymore.Also updated the test to accommodate for the behavior change.
Fixes #107
cc @wangmengyan95 since it looks like you changed this explicitly at some point and tests blame to you.