pg-promise refactoring

[vitaly-t]

initial refactoring of pg-promise code.

[vitaly-t]

The issue on Travis CI is unrelated to the change.

[flovilmart]

If you rebase on master this should be good!

[flovilmart]

What’s the relationale behind the dash-cased tx names vs camelCase? Just conventions?

[vitaly-t]

@flovilmart yes, just conventions. Also, in line with the use of pg-monitor, which I believe you guys are not using, though it is very useful, to be able to see exactly what is going on. 😉

[codecov]

Codecov Report

Merging #4401 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4401      +/-   ##
==========================================
- Coverage   92.66%   92.64%   -0.03%     
==========================================
  Files         118      118              
  Lines        8348     8346       -2     
==========================================
- Hits         7736     7732       -4     
- Misses        612      614       +2

Impacted Files	Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js	96.83% <100%> (-0.01%)	⬇️
src/Adapters/Auth/meetup.js	84.21% <0%> (-5.27%)	⬇️
src/RestWrite.js	93.1% <0%> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eed81e...06606fb. Read the comment docs.

[vitaly-t]

@flovilmart I should have just used ES6 yield for now, which works the same, will do in another PR ;) Those will be directly convertible into await/async ;)

[flovilmart]

Let’s try not to have Babel regenerator runtime as we’ve had performance problems with it in the past, that’s why I aim to maintain the minimum amount of transpilation and move forward with LTS. Now we’re targeting 6.11. And we could /should probably target current LTS. What do you think?

[vitaly-t]

@flovilmart That's absolutely not what I suggested. ES6 generators are supported since Node 4 😉 Also, I never use Babel for anything, not a fan of its over-the-head project configurations 😄

[flovilmart]

Perfect then! Wasn’t sure since when they were available .)