Improvements for sending push performance#4122
Merged
flovilmart merged 3 commits intomasterfrom Aug 29, 2017
Merged
Conversation
Contributor
flovilmart
commented
Aug 29, 2017
- Makes the ordering on objectId, to reduce the need of additional and potentially costly indexes
- Do not order on badge, but group inside the batch
- Mark all push status objects with audience of 0 as failed.
- Make sure we always filter valid installations on all operations with "deviceToken: {$exists: true}"
Codecov Report
@@ Coverage Diff @@
## master #4122 +/- ##
==========================================
+ Coverage 90.73% 90.74% +<.01%
==========================================
Files 116 116
Lines 7937 7939 +2
==========================================
+ Hits 7202 7204 +2
Misses 735 735
Continue to review full report at Codecov.
|
natanrolnik
approved these changes
Aug 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.