Skip to content

Improvements for sending push performance#4122

Merged
flovilmart merged 3 commits intomasterfrom
push-ordering
Aug 29, 2017
Merged

Improvements for sending push performance#4122
flovilmart merged 3 commits intomasterfrom
push-ordering

Conversation

@flovilmart
Copy link
Contributor

  • Makes the ordering on objectId, to reduce the need of additional and potentially costly indexes
  • Do not order on badge, but group inside the batch
  • Mark all push status objects with audience of 0 as failed.
  • Make sure we always filter valid installations on all operations with "deviceToken: {$exists: true}"

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #4122 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4122      +/-   ##
==========================================
+ Coverage   90.73%   90.74%   +<.01%     
==========================================
  Files         116      116              
  Lines        7937     7939       +2     
==========================================
+ Hits         7202     7204       +2     
  Misses        735      735
Impacted Files Coverage Δ
src/Push/utils.js 100% <100%> (ø) ⬆️
src/Controllers/PushController.js 95.45% <100%> (ø) ⬆️
src/Push/PushWorker.js 92.45% <100%> (ø) ⬆️
src/Push/PushQueue.js 100% <100%> (+3.44%) ⬆️
src/RestWrite.js 92.97% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd7bc0...8c45160. Read the comment docs.

@flovilmart flovilmart merged commit ea67d23 into master Aug 29, 2017
@flovilmart flovilmart deleted the push-ordering branch August 29, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants