Fixes issue affecting linking users to a 3rd party auth#4047
Merged
flovilmart merged 4 commits intomasterfrom Jul 25, 2017
Merged
Fixes issue affecting linking users to a 3rd party auth#4047flovilmart merged 4 commits intomasterfrom
flovilmart merged 4 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4047 +/- ##
==========================================
+ Coverage 90.7% 90.71% +<.01%
==========================================
Files 116 116
Lines 7911 7916 +5
==========================================
+ Hits 7176 7181 +5
Misses 735 735
Continue to review full report at Codecov.
|
Contributor
Author
|
The JS SDK has a bug, all login calls are treated as link calls, unlike the other SDK'S I'll open issues there as well. The JS SDK should just strip the sessionToken when sending a login call |
flovilmart
force-pushed
the
issue/linking-authenticated-user
branch
from
bfe1c24 to
10155a1
Compare
acinader
approved these changes
Jul 25, 2017
Contributor
Author
|
Thanks @acinader :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linking a user to an oauth provider in a client SDK (verified on iOS), the server would not check the session token for the authenticated user and the url doesn't hold the userId part of it (send as /users instead of /users/:id)
This PR addresses that issue, the userId provided by the session token will always take precedence over the query provided ID.
This should not break any installation as this server behaviour was not expected by the clients.