support file DELETEs

[westhom]

e.g.

curl -X DELETE \
        -H "X-Parse-Application-Id: <app_id>" \
        -H "X-Parse-Master-Key: <master_key>" \
        http://localhost:1337/files/2e85ede1e439506909e1a388710fc2b8_hey.jpg

Returns empty 200 on success, but probably wants to return useful JSON instead? Fixes #340

[nlutsenko]

r stands for reading mode here, I honestly expect it not to work for file deletions.

[nlutsenko]

This is pretty exciting! Good job on implementing this!
Except of that nit, few thoughts and requests:

• Can we have at least a single e2e test? Look at some of the basic tests in ParseFile.spec.js, we probably would want something REST-api based and e2e full (create/read/delete/read).
• We need to enforce master-key security on this, since anyone with an appid/any-key will be able to delete files, which is pretty bad.

[westhom]

@nlutsenko Thanks for reviewing. I'll add in an e2e test to the PR. Regarding master-key security, I have a check in the deletionHandler for req.auth.isMaster, which seems to be working-- I can't delete images if I don't have X-Parse-Master-Key set correctly. Better way of doing this?

In any event, I'll also add a test for unauthenticated deletion attempt.

[nlutsenko]

Sorry, totally missed it, you are absolutely correct.

[facebook-github-bot]

@westhom updated the pull request.

[facebook-github-bot]

@westhom updated the pull request.

[facebook-github-bot]

@westhom updated the pull request.

[westhom]

Added to ParseFile spec:

• REST file end-to-end coverage for create, read, delete, read
• verify you cannot delete file with incorrect or missing X-Parse-Master-Key

[facebook-github-bot]

@westhom updated the pull request.

[nlutsenko]

Looks great! So glad we have this now!

[ishaan1995]

Closed issue--> #340
The file delete is still not working, i have update the parse-server code today, that has the commit for file delete, but still the same error occurs as mentioned above.
It seems as the master key is doing nothing because even if i do not enter the master key, i get that same error--> cannot delete /parse/....