Allow empty client key#3497
Merged
hramos merged 2 commits intoparse-community:masterfrom Feb 10, 2017
Merged
Conversation
added 2 commits
February 9, 2017 14:50
Simply checking if they are truthy causes a false negative if the value is ''.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #3486
FYI, I tried solving with
_.has(obj, key), but that gives false positives. I found that in the case of our current coverage and doing my best to reason over the relevant code that a test ofundefinedwould both "do what we want" and be backwards compatible.