Ensure beforeSave hook response is object before stripping#1969
Merged
drew-gross merged 1 commit intoparse-community:masterfrom Jun 1, 2016
Merged
Ensure beforeSave hook response is object before stripping#1969drew-gross merged 1 commit intoparse-community:masterfrom
drew-gross merged 1 commit intoparse-community:masterfrom
Conversation
ghost
added
the
Current coverage is 91.88%@@ master #1969 diff @@
==========================================
Files 91 91
Lines 6405 6406 +1
Methods 1094 1094
Messages 0 0
Branches 1344 1345 +1
==========================================
+ Hits 5885 5886 +1
Misses 520 520
Partials 0 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically if someone returns true/false boolean primitives it'll behave just fine if you call delete on them as the primitive values get converted to objects by the interpreter but this is more explicit.