fix bug in show defaults when using a flag option and a default map #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdur-rahmaanJ
left a comment
Abdur-rahmaanJ
left a comment
There was a problem hiding this comment.
LGTM, added
- relevant changes to CHANGES.rst
- unit-test to test if issue solved
- fix for the issue
Thanks @ChrisPappalardo for being thoughtful while working on this 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In latest main, when a flag option is used with
show_default=Trueand adefault_mapis passed,--helpshows the default value in the decorator and not the value in the default map.This PR does two things:
fixes #2632