Parse Sabre Exception in OC.Files.Client and file-upload#28620
Merged
Parse Sabre Exception in OC.Files.Client and file-upload#28620
Conversation
In case of error, instead of a generic error message, an upload will display whichever message is returned in the Sabre Exception, if applicable.
Contributor
Author
|
Yes, I did have to parse the sabre exception in two places... This is really messy because we have multiple ways of doing queries, and the one for the PUT upload is managed by jquery.fileupload, so it needed its own code path... I hope one day we can find a way to consolidate all. @VicDeo please review and test with owncloud/files_antivirus#163 |
Member
|
I don't think there is a good way out for this... |
Member
|
Master This branch so yes, fixes owncloud/files_antivirus#163 |
VicDeo
approved these changes
Aug 9, 2017
Contributor
Author
|
Thanks, guys! |
Contributor
Author
|
stable10: #28635 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case of error, instead of a generic error message, an upload will
display whichever message is returned in the Sabre Exception, if
applicable.
Related Issue
Part of #24304.
Should fix owncloud/files_antivirus#163
Motivation and Context
See #24304
How Has This Been Tested?
I manually tested this by triggering Sabre exception on upload from the server side (hard-coded exception). Tested with chunked upload error and regular upload error. The message from the server is displayed in the client.
Screenshots (if appropriate):
Types of changes
Checklist: