Truncate mtime passed to X-OC-Mtime in web UI uploads#28050
Truncate mtime passed to X-OC-Mtime in web UI uploads#28050
Conversation
|
Confirmed working by reporters: #27960 |
Some envs seem to have a higher timer resolution which would cause a float value to be sent, which isn't supported by the server.
PVince81
force-pushed
the
truncate-upload-mtime
branch
from
8fb3e29 to
b6709a3
Compare
|
We should fix this server side as well ..... ? |
|
Yes, see #27960 (comment) |
|
It's done here: #28066 Can we merge this JS only PR ? |
@DeepDiver1975 asking you since you had an objection above |
|
#28066 does the truncating at the back-end, and is in master and stable10. So the server will handle being passed finer-resolution timestamps. For the future it might be nicer to do nothing here (or in any client), then it leaves it up to the server to decide what resolution it can (or wants to) apply to timestamps. The server could introduce finer-resolution some day and clients that send more resolution would just start to get it. |
|
@phil-davis sounds good. Also some servers like Cernbox seems to have float mtimes from what I saw here owncloud/files_texteditor#172, so let's leave it as is cc @moscicki |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Description
Some envs seem to have a higher timer resolution which would cause
a float value to be sent, which isn't supported by the server.
Related Issue
Fixes #27960
Motivation and Context
How Has This Been Tested?
Tested locally with a debugger to see that the mtime still looks good.
But I don't have an env to reproduce the decimal issue to really confirm.
Screenshots (if appropriate):
Types of changes
Checklist: