Skip to content

feat(): map area filter#273

Open
strech345 wants to merge 6 commits intoorangecoding:masterfrom
strech345:feature/map_area_filter
Open

feat(): map area filter#273
strech345 wants to merge 6 commits intoorangecoding:masterfrom
strech345:feature/map_area_filter

Conversation

@strech345
Copy link

  • add spatial_filter to db from type geoJson or null
  • add areaFilter Map to a job config
  • create Map component
  • create MapDrawingExtension
  • use spatial_filter to filter listings

@orangecoding
Copy link
Owner

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2739fab10d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Owner

@orangecoding orangecoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Thanks for the effort you put into this. Looks great. A couple of comments though.. Also pretty much all tests are broken. Can you fix this please?

@strech345
Copy link
Author

Hey. Thanks for the effort you put into this. Looks great. A couple of comments though.. Also pretty much all tests are broken. Can you fix this please?

there are still provider tests failing (immobilien.de), also on master branch, Looks like 403 (Bot Protection) at least for my ip.

@strech345
Copy link
Author

@orangecoding i would also like to add spec filters: for minSquareMeters, minRools and maxPrice. Would add it in same way like the areaFilter if this ok for you.

@orangecoding
Copy link
Owner

orangecoding commented Mar 3, 2026

@orangecoding i would also like to add spec filters: for minSquareMeters, minRools and maxPrice. Would add it in same way like the areaFilter if this ok for you.

Sure go ahead. Please ping me when done, I'll wait with the review until you're done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants