Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2739fab10d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
orangecoding
left a comment
There was a problem hiding this comment.
Hey. Thanks for the effort you put into this. Looks great. A couple of comments though.. Also pretty much all tests are broken. Can you fix this please?
ui/src/views/jobs/mutation/components/areaFilter/AreaFilter.less
Outdated
Show resolved
Hide resolved
there are still provider tests failing (immobilien.de), also on master branch, Looks like 403 (Bot Protection) at least for my ip. |
|
@orangecoding i would also like to add spec filters: for minSquareMeters, minRools and maxPrice. Would add it in same way like the areaFilter if this ok for you. |
Sure go ahead. Please ping me when done, I'll wait with the review until you're done. |
spatial_filterto db from typegeoJsonornullMapcomponentMapDrawingExtensionspatial_filterto filter listings