docs: update incremental benchmarks (3.6.0)#714
docs: update incremental benchmarks (3.6.0)#714github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
Greptile SummaryThis automated PR updates Key changes:
All figures cross-check correctly: Confidence Score: 5/5Safe to merge — documentation-only change with no code impact; all data is internally consistent and the previous reviewer concern has been addressed. No P0 or P1 issues found. All numeric values in the summary table, Latest results section, and embedded JSON are mutually consistent. The blockquote note explaining the absent native row directly addresses the prior review thread. The PR is a routine automated docs update. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant WF as GitHub Actions Workflow #538
participant BH as Benchmark Harness
participant NE as Native Engine
participant WE as WASM Engine
participant RR as Resolve Runner
participant MD as INCREMENTAL-BENCHMARKS.md
WF->>BH: trigger benchmark run (v3.6.0)
BH->>NE: run full / no-op / 1-file rebuild
NE-->>BH: SQLITE_CORRUPT (WAL corruption)<br/>detect-changes → purgeAndAddReverseDeps
BH->>WE: run full / no-op / 1-file rebuild
WE-->>BH: fullBuildMs=6128, noopMs=13, 1fileMs=545
BH->>RR: run import resolution (native + JS)
RR-->>BH: nativeBatchMs=3.9, jsFallbackMs=11.7, imports=904
BH->>MD: prepend 3.6.0 JSON entry (native: null)
BH->>MD: update summary table row (wasm only)
BH->>MD: update Latest results section + add WAL note
WF->>WF: open PR #714
Reviews (2): Last reviewed commit: "docs(benchmarks): explain missing native..." | Re-trigger Greptile |
|
|
||
| | Version | Engine | Files | Full Build | No-op | 1-File | Resolve (native) | Resolve (JS) | | ||
| |---------|--------|------:|-----------:|------:|-------:|------------------:|-------------:| | ||
| | 3.6.0 | wasm | 514 | 6.1s | 13ms | 545ms | 4ms ↓3% | 12ms ↑9% | |
There was a problem hiding this comment.
Missing native engine row with no explanation
3.6.0 has "native": null in the embedded JSON data, so only a wasm row appears in the summary table. For 3.5.0, the workflow generated a <!-- NOTES_START --> ... <!-- NOTES_END --> block explaining why both engines were null (napi-rs serialization bug, WAL race condition). That note has now been removed since 3.6.0 is the latest.
However, native was working in 3.4.1, and readers of this file have no indication of why the native engine is absent for 3.6.0. It may be worth adding a brief note in the "Latest results" section (or a comment in the JSON entry) explaining whether the native engine was intentionally skipped, failed during the benchmark run, or is being phased out.
There was a problem hiding this comment.
Addressed. Added a blockquote note in the "Latest results" section explaining that the native engine crashed with SQLITE_CORRUPT during the incremental rebuild tier (WAL corruption in detect-changes / purgeAndAddReverseDeps). See 839aa86.
Native worker crashed with SQLITE_CORRUPT during incremental rebuild (WAL corruption in detect-changes). Add a note so readers understand why only the WASM row appears.
|
@greptileai review |
Automated incremental benchmark update for 3.6.0 from workflow run #538.