-
Notifications
You must be signed in to change notification settings - Fork 4
docs: add community leverage features to backlog (IDs 100-102) #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5f1a11d
docs: add community leverage features to backlog (IDs 97-99)
carlos-alm 39a3c19
Merge branch 'main' into docs/backlog-leiden-features
carlos-alm c97b217
fix(backlog): renumber community items to IDs 100-102, fix Leiden text
carlos-alm afc420d
Merge remote-tracking branch 'origin/docs/backlog-leiden-features' in…
carlos-alm 41a0329
Merge branch 'main' into docs/backlog-leiden-features
carlos-alm 7f4a036
docs: rename Tier 1e′ to Tier 1e.1 for ASCII compatibility
carlos-alm 61b11c9
docs: fix premature Leiden references in backlog
carlos-alm 9217342
docs: add #545 dependency to community leverage items 100-102
carlos-alm e87760c
docs: add #545 dependency to item #54 for Leiden consistency
carlos-alm d2dc8e6
Merge branch 'main' into docs/backlog-leiden-features
carlos-alm c52a75a
docs: mark #96 as SUPERSEDED instead of BLOCKED
carlos-alm c328798
Merge branch 'docs/backlog-leiden-features' of https://github.com/opt…
carlos-alm 9e92044
Merge branch 'main' into docs/backlog-leiden-features
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DONE note reads: "
graphologyandgraphology-communities-louvainremoved by vendoring Leiden algorithm. Runtime dependency count is now back to 3." However, both packages are still present as runtime dependencies inpackage.json:And
src/graph/algorithms/louvain.jsstill importsgraphology-communities-louvainas its algorithm backend. The Leiden vendoring (which this DONE justification is predicated on) has not actually been merged — there is nosrc/graph/algorithms/leiden/directory in the repository. Marking #96 as DONE here is premature and will mislead readers into thinking the dependency count is already 3 when it is still 5.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — reverted #96 from DONE to BLOCKED on #545. graphology and graphology-communities-louvain are still live runtime dependencies until the Leiden vendoring PR merges.