Set default timeout in download.stream_file to 10 seconds, and allow to override value#222
Merged
Set default timeout in download.stream_file to 10 seconds, and allow to override value#222
download.stream_file to 10 seconds, and allow to override value#222Conversation
benoit74
force-pushed
the
requests_timeout
branch
from
6984c83 to
3a9fe52
Compare
benoit74
changed the title
download.stream_file to 10 seconds, and allow to override value
benoit74
force-pushed
the
requests_timeout
branch
from
3a9fe52 to
537f251
Compare
…w to override value
benoit74
force-pushed
the
requests_timeout
branch
from
537f251 to
7ddea55
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 2224 2226 +2
Branches 426 426
=========================================
+ Hits 2224 2226 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never passed a timeout to these requests call, but obviously we should have (this seems to be the explanation to openzim/mindtouch#80 so far)