-
-
Notifications
You must be signed in to change notification settings - Fork 19
Enhance tags manipulation #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oups, CI is failing, I've requested review too early, sorry |
|
Arf, this has nothing to do with my change, it is Vimeo returning 403 on yt_dlp tests ... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1439 1448 +9
Branches 248 251 +3
=========================================
+ Hits 1439 1448 +9 ☔ View full report in Codecov by Sentry. |
|
Moved to Jeena Peertube instance instead of Vimeo ... this will work the time it will ... |
rgaudin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I find it odd to specify default tags as iterable and user ones as string but I understand it's because default is immutable from constant and user ones from CLI
|
Yep, maybe we could support both types for both variables, but there is no use-case as far as I can tell and we've agreed to not implement something "should it become a need somewhere in the future". |
Fix #164
Fix #156
Changes:
This does not deduplicate automatically tags, it is still the scraper responsibility to properly pass tags (ideally with the new utility function) since
config_metadatais more a wrapper passing directly the values as-is, I did not wanted to make an exception for tagsEdit: I had to also modify URL used for yt-dlp tests because former Vimeo URL is now returning a 403 on Github runners. Hopefully the new Jeena Peertube instance will be a little bit more permissive for few years ...