Skip to content

[qa] Enforce consistent string quoting style (double quotes) #451#456

Merged
nemesifier merged 5 commits intoopenwisp:masterfrom
aoutifrak:master
May 24, 2025
Merged

[qa] Enforce consistent string quoting style (double quotes) #451#456
nemesifier merged 5 commits intoopenwisp:masterfrom
aoutifrak:master

Conversation

@aoutifrak
Copy link
Contributor

@aoutifrak aoutifrak commented Apr 1, 2025

  • Removed flag from function to ensure Black enforces double quotes.
  • Updated the script to fail if Black detects incorrect string formatting.

Fixes #451

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • N/A I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • N/A I have updated the documentation.

- Removed  flag from  function to ensure Black enforces double quotes.
- Updated the script to fail if Black detects incorrect string formatting.

Fixes openwisp#451
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoutifrak you can reopen this, we'll merge once ready.

@aoutifrak
Copy link
Contributor Author

ok

aoutifrak

This comment was marked as duplicate.

@aoutifrak aoutifrak reopened this Apr 4, 2025
@coveralls
Copy link

Coverage Status

coverage: 95.962%. remained the same
when pulling 92c6298 on aoutifrak:master
into ad85b27 on openwisp:master.

@nemesifier nemesifier merged commit 7c5169e into openwisp:master May 24, 2025
18 checks passed
@nemesifier nemesifier changed the title [qa] Enforce consistent string quoting style #451 [qa] Enforce consistent string quoting style (double quotes) #451 May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[qa] Enforce consistent string quoting style

3 participants