Conversation
Member
|
Overall, this looks good. I think we do need to add POD to this and I would recommend a test file, but I have started one and can add it later. |
Alex-Jordan
force-pushed
the
matrix-boolean
branch
from
d4363f9 to
798abf5
Compare
pstaabp
approved these changes
Apr 3, 2024
drgrice1
reviewed
Apr 5, 2024
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
This looks good other than the lack of the min method.
drgrice1
reviewed
Apr 5, 2024
Co-authored-by: Glenn Rice <47527406+drgrice1@users.noreply.github.com>
Contributor
Author
I committed your suggestion for doing it directly. |
Member
|
This can be merged I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1012, adding some boolean methods:
isUpperTriangular,isLowerTriangular,isDiagonal,isSymmetric,isREF,isRREF, andisOrthogonal. In some places, the code could have been shorter and more elegant, but I tried to lean toward efficiency. For example,isSymmetriccould have simply asked if$self == $self->transpose, but I suspect what is here is a little faster.These will help with custom answer checkers in a linear algebra course. For example asking a student to orthogonally diagonalize a matrix.