feat：Drag Handle Check

[STATICHIT]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

feat：Drag Handle Check

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Enhanced the Plugin Panel with conditional rendering for resizer elements, improving component responsiveness.
  • Introduced new functions for dynamic plugin width management and layout retrieval.

• Bug Fixes

  • Improved plugin alignment handling to ensure correct display based on layout configuration.

• Chores

  • Simplified the addons configuration by removing unnecessary plugin retrieval logic.

[coderabbitai]

Walkthrough

The changes introduce enhancements to the PluginPanel component by implementing conditional rendering for resizers based on layout states. New functions for managing plugin dimensions and layout properties are added to the useLayout module. Additionally, the addons configuration is simplified by removing the dynamic plugin retrieval logic, focusing solely on the addons object.

Changes

Files	Change Summary
packages/common/component/PluginPanel.vue	Added conditional rendering for resizers and introduced getPluginByLayout method to manage plugin alignment, creating reactive references for resizer visibility.
packages/controller/src/useLayout.js	Introduced getPluginWidth, changePluginWidth, and getPluginByLayout functions for improved plugin management, enhancing width and layout property control.
packages/design-core/config/addons.js	Removed the dynamic plugin retrieval logic, simplifying the addons export to only include the addons object without associated functions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PluginPanel
    participant useLayout

    User->>PluginPanel: Interacts with plugin
    PluginPanel->>useLayout: getPluginByLayout(fixedName)
    useLayout-->>PluginPanel: Returns alignment
    PluginPanel->>PluginPanel: Update isLeftResizer, isRightResizer
    PluginPanel->>User: Render updated view

Loading

🐰 "Oh, what a change, so bright and new,
Resizers appear, just for you!
With width and layout, we dance and play,
In the world of plugins, hip-hip-hooray!
No more clutter, just clean and neat,
Hopping along to a rhythmic beat!" 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)

packages/common/component/PluginPanel.vue (1)

73-73: Approve the changes and suggest adding comments for clarity.

The inclusion of getPluginByLayout in the setup function and the creation of isLeftResizer and isRightResizer are well-implemented. These changes dynamically adjust the visibility of resizers based on the plugin's layout alignment. Consider adding comments to explain how these reactive references are derived from the alignment data for better maintainability.

+ // Determine the alignment of the plugin to set resizer visibility
  const align = ref(getPluginByLayout(props.fixedName))
  const isLeftResizer = ref(align.value.includes('left'))
  const isRightResizer = ref(align.value.includes('right'))

Also applies to: 112-115

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fa2ca2f and d913400.

Files selected for processing (3)

• packages/common/component/PluginPanel.vue (4 hunks)
• packages/controller/src/useLayout.js (2 hunks)
• packages/design-core/config/addons.js (1 hunks)

Files skipped from review due to trivial changes (1)

• packages/design-core/config/addons.js

Additional comments not posted (2)

packages/controller/src/useLayout.js (2)

176-176: LGTM!

The function changePluginWidth correctly checks for the existence of the plugin before updating its width.

---

183-183: LGTM!

The function getPluginByLayout correctly defaults to 'leftTop' if the alignment property is not defined, enhancing the functionality by allowing access to layout-related properties of plugins.