Conversation
WalkthroughPatch-level release update to 2.8.2 across multiple packages and templates. One code change modifies import map resolution in design-core preview to optionally use a custom import map from engine config, adjusting placeholder replacement logic and call sites accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Preview as Preview UI
participant ImportMap as ImportMapResolver
participant Meta as MetaRegister
participant CDN as CDN Placeholders
Preview->>ImportMap: getImportMap()
ImportMap->>Meta: getMergeMeta('engine.config')
Meta-->>ImportMap: engine.config (may include importMap)
alt custom importMap provided
loop for each (k, v) in imports
ImportMap->>ImportMap: replacePlaceholder(v, k) using customImportMap.imports[k]
end
else no custom map
loop for each (k, v) in imports
ImportMap->>CDN: apply VITE_CDN_DOMAIN, versionDelimiter, fileDelimiter, opentinyVueVersion
end
end
ImportMap-->>Preview: resolved import map
Note over ImportMap,Preview: Falls back to existing placeholders when no per-key override exists.
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (55)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2024-12-14T05:53:28.501ZApplied to files:
📚 Learning: 2024-09-30T07:51:10.036ZApplied to files:
🧬 Code graph analysis (1)packages/design-core/src/preview/src/preview/importMap.js (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Chores