fix: sub page hide show setting home option

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Updated page tree operations so that the 'set as home' option is only available for top-level pages that are not in the 'public' group.

[coderabbitai]

Walkthrough

The logic in the getRowOperations function within PageTree.vue was updated to further restrict the 'settingHome' operation. Now, 'settingHome' is only available for nodes that are pages, not in the 'public' group, and have a parent ID of exactly '0'.

Changes

File	Change Summary
packages/plugins/page/src/PageTree.vue	Updated getRowOperations to add parentId '0' check for filtering 'settingHome' operation.

Estimated code review effort

1 (~2 minutes)

Poem

In the forest of pages, a rule now is shown,
Only root-level bunnies may call a home their own.
If you’re not at the top, or your group isn’t right,
The 'settingHome' carrot stays just out of sight.
Hop along, little node, and find your place—
The logic is clear in this codey space! 🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2edf50c and 0a31767.

📒 Files selected for processing (1)

• packages/plugins/page/src/PageTree.vue (1 hunks)

🧠 Learnings (2)

📓 Common learnings

Learnt from: gene9831
PR: opentiny/tiny-engine#1041
File: packages/plugins/datasource/src/DataSourceList.vue:138-138
Timestamp: 2025-01-14T10:06:25.508Z
Learning: PR #1041 in opentiny/tiny-engine is specifically for reverting Prettier v3 formatting to v2, without any logical code changes or syntax improvements.

Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/RenderMain.ts:82-88
Timestamp: 2025-01-14T08:50:50.226Z
Learning: For PR #1011, the focus is on resolving conflicts and migrating code, with architectural improvements deferred for future PRs.

Learnt from: gene9831
PR: opentiny/tiny-engine#1011
File: packages/plugins/page/src/PageTree.vue:340-345
Timestamp: 2025-01-14T08:37:01.393Z
Learning: The code in PageTree.vue is based on template code copied from elsewhere and will be refactored later, so suggestions for improvements should be deferred until that refactoring occurs.

Learnt from: gene9831
PR: opentiny/tiny-engine#1011
File: packages/plugins/page/src/PageGeneral.vue:166-178
Timestamp: 2025-01-14T06:40:18.223Z
Learning: The page structure data in PageGeneral.vue cannot have circular dependencies due to design constraints.

Learnt from: gene9831
PR: opentiny/tiny-engine#1069
File: packages/plugins/page/src/PageGeneral.vue:107-107
Timestamp: 2025-01-24T07:30:38.528Z
Learning: In PageGeneral.vue, `pageParentId.value` is only used to initialize the `oldParentId` ref. After initialization, `oldParentId` is kept in sync with `pageSettingState.oldParentId` through a watchEffect.

packages/plugins/page/src/PageTree.vue (7)

Learnt from: gene9831
PR: #1011
File: packages/plugins/page/src/PageTree.vue:340-345
Timestamp: 2025-01-14T08:37:01.393Z
Learning: The code in PageTree.vue is based on template code copied from elsewhere and will be refactored later, so suggestions for improvements should be deferred until that refactoring occurs.

Learnt from: gene9831
PR: #1069
File: packages/plugins/page/src/PageGeneral.vue:107-107
Timestamp: 2025-01-24T07:30:38.528Z
Learning: In PageGeneral.vue, pageParentId.value is only used to initialize the oldParentId ref. After initialization, oldParentId is kept in sync with pageSettingState.oldParentId through a watchEffect.

Learnt from: gene9831
PR: #1011
File: packages/plugins/page/src/PageGeneral.vue:166-178
Timestamp: 2025-01-14T06:40:18.223Z
Learning: The page structure data in PageGeneral.vue cannot have circular dependencies due to design constraints.

Learnt from: chilingling
PR: #1440
File: packages/plugins/materials/src/composable/useResource.ts:82-84
Timestamp: 2025-05-28T03:58:31.212Z
Learning: In the TinyEngine codebase, there are two different data structures for page information:

1. App schema components tree (appSchemaState.pageTree) uses nested meta structure with page.meta?.id
2. API responses from pagePluginApi.getPageById() return flattened structure with pageInfo.id and pageInfo.occupier directly
   The code should use page.meta?.id when working with pageTree data and pageInfo.id when working with API response data.

Learnt from: gene9831
PR: #1011
File: packages/plugins/page/src/Tree.vue:80-101
Timestamp: 2025-01-14T06:42:57.361Z
Learning: The page tree structure in tiny-engine does not have deep nesting scenarios, so recursion depth protection is not required in tree traversal functions.

Learnt from: rhlin
PR: #1061
File: packages/plugins/materials/src/composable/useResource.js:41-55
Timestamp: 2025-01-22T08:16:44.620Z
Learning: In the tiny-engine project, specifically in the URL manipulation for pages, validation for pageId=0 is not required as it's not a valid use case that needs to be handled.

Learnt from: rhlin
PR: #1011
File: packages/vue-generator/src/plugins/genRouterPlugin.js:122-125
Timestamp: 2025-01-14T11:09:32.013Z
Learning: The router configuration in Vue Generator should maintain the current structure without a catch-all route for 404 handling or modification to the root path prefix, as these are not required at this time.

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: gene9831
PR: opentiny/tiny-engine#1041
File: packages/plugins/datasource/src/DataSourceList.vue:138-138
Timestamp: 2025-01-14T10:06:25.508Z
Learning: PR #1041 in opentiny/tiny-engine is specifically for reverting Prettier v3 formatting to v2, without any logical code changes or syntax improvements.

Learnt from: rhlin
PR: opentiny/tiny-engine#1011
File: packages/canvas/render/src/RenderMain.ts:82-88
Timestamp: 2025-01-14T08:50:50.226Z
Learning: For PR #1011, the focus is on resolving conflicts and migrating code, with architectural improvements deferred for future PRs.

Learnt from: gene9831
PR: opentiny/tiny-engine#1011
File: packages/plugins/page/src/PageTree.vue:340-345
Timestamp: 2025-01-14T08:37:01.393Z
Learning: The code in PageTree.vue is based on template code copied from elsewhere and will be refactored later, so suggestions for improvements should be deferred until that refactoring occurs.

Learnt from: gene9831
PR: opentiny/tiny-engine#1011
File: packages/plugins/page/src/PageGeneral.vue:166-178
Timestamp: 2025-01-14T06:40:18.223Z
Learning: The page structure data in PageGeneral.vue cannot have circular dependencies due to design constraints.

Learnt from: gene9831
PR: opentiny/tiny-engine#1069
File: packages/plugins/page/src/PageGeneral.vue:107-107
Timestamp: 2025-01-24T07:30:38.528Z
Learning: In PageGeneral.vue, `pageParentId.value` is only used to initialize the `oldParentId` ref. After initialization, `oldParentId` is kept in sync with `pageSettingState.oldParentId` through a watchEffect.

packages/plugins/page/src/PageTree.vue (7)

Learnt from: gene9831
PR: #1011
File: packages/plugins/page/src/PageTree.vue:340-345
Timestamp: 2025-01-14T08:37:01.393Z
Learning: The code in PageTree.vue is based on template code copied from elsewhere and will be refactored later, so suggestions for improvements should be deferred until that refactoring occurs.

Learnt from: gene9831
PR: #1069
File: packages/plugins/page/src/PageGeneral.vue:107-107
Timestamp: 2025-01-24T07:30:38.528Z
Learning: In PageGeneral.vue, pageParentId.value is only used to initialize the oldParentId ref. After initialization, oldParentId is kept in sync with pageSettingState.oldParentId through a watchEffect.

Learnt from: gene9831
PR: #1011
File: packages/plugins/page/src/PageGeneral.vue:166-178
Timestamp: 2025-01-14T06:40:18.223Z
Learning: The page structure data in PageGeneral.vue cannot have circular dependencies due to design constraints.

Learnt from: chilingling
PR: #1440
File: packages/plugins/materials/src/composable/useResource.ts:82-84
Timestamp: 2025-05-28T03:58:31.212Z
Learning: In the TinyEngine codebase, there are two different data structures for page information:

1. App schema components tree (appSchemaState.pageTree) uses nested meta structure with page.meta?.id
2. API responses from pagePluginApi.getPageById() return flattened structure with pageInfo.id and pageInfo.occupier directly
   The code should use page.meta?.id when working with pageTree data and pageInfo.id when working with API response data.

Learnt from: gene9831
PR: #1011
File: packages/plugins/page/src/Tree.vue:80-101
Timestamp: 2025-01-14T06:42:57.361Z
Learning: The page tree structure in tiny-engine does not have deep nesting scenarios, so recursion depth protection is not required in tree traversal functions.

Learnt from: rhlin
PR: #1061
File: packages/plugins/materials/src/composable/useResource.js:41-55
Timestamp: 2025-01-22T08:16:44.620Z
Learning: In the tiny-engine project, specifically in the URL manipulation for pages, validation for pageId=0 is not required as it's not a valid use case that needs to be handled.

Learnt from: rhlin
PR: #1011
File: packages/vue-generator/src/plugins/genRouterPlugin.js:122-125
Timestamp: 2025-01-14T11:09:32.013Z
Learning: The router configuration in Vue Generator should maintain the current structure without a catch-all route for 404 handling or modification to the root path prefix, as these are not required at this time.

🔇 Additional comments (1)

packages/plugins/page/src/PageTree.vue (1)

276-276: LGTM! Good business logic improvement.

This change correctly restricts the "设置为主页" (Set as Homepage) option to only top-level pages (parentId='0'). This aligns with the PR objective to fix sub-page home setting visibility and makes logical sense - typically only root-level pages should be eligible as homepage candidates, not nested sub-pages.

The String() conversion ensures type-safe comparison regardless of whether parentId is stored as a number or string.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.