Skip to content

fix: remove warning infos#1391

Merged
chilingling merged 2 commits intoopentiny:developfrom
SonyLeo:fix/warnings
May 15, 2025
Merged

fix: remove warning infos#1391
chilingling merged 2 commits intoopentiny:developfrom
SonyLeo:fix/warnings

Conversation

@SonyLeo
Copy link
Contributor

@SonyLeo SonyLeo commented May 13, 2025

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

存在部分警告信息

  1. Extraneous non-emits event listeners(changeLeftAlign) ...

  2. Property 'left' was accessed during render but is not defined on instance ...

Issue Number: N/A

What is the new behavior?

消除相应的警告信息

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features
    • Added support for a new prop to accept fixed panels in settings.
    • Introduced event emission for left and right alignment changes in design-related components.
  • Improvements
    • Alignment handling is now more explicit and robust in design plugin menus.
    • Enhanced event declaration for better integration with Vue 3 standards.
  • Refactor
    • Updated visibility logic for the design settings panel for more predictable rendering.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 13, 2025

Walkthrough

The updates fix a prop binding by replacing an undefined variable with a string literal, add new event declarations for alignment changes in Vue components, remove a conditional visibility directive, and introduce a new prop to accept an array of fixed panels.

Changes

File(s) Change Summary
packages/layout/src/DesignPlugins.vue Fixed align prop by replacing left variable with string "left", added 'changeLeftAlign' event to emits, and emit this event in switchAlign method.
packages/layout/src/DesignSettings.vue Added emits: ['changeRightAlign'] declaration to register the emitted event.
packages/layout/src/Main.vue Removed v-show="layoutState.settings.showDesignSettings" directive from <design-settings>.
packages/settings/props/src/Main.vue Added new prop fixedPanels of type Array.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DesignPlugins
    participant ParentComponent

    User->>DesignPlugins: Triggers switchAlign()
    DesignPlugins->>ParentComponent: Emits changeLeftAlign
Loading

Poem

In the garden of code, a new constant takes flight,
LEFT aligns the menu, making everything right.
Events now declared, no more guessing games,
Fixed panels arrive, with shiny new names.
The settings peek out, the logic refined—
A hop and a skip, all features aligned!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f25206 and a80cf4c.

📒 Files selected for processing (1)
  • packages/layout/src/DesignPlugins.vue (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/layout/src/DesignPlugins.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: push-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label May 13, 2025
hexqi
hexqi previously approved these changes May 14, 2025
:settings="registry.settings"
:render-panel="settings.render"
:plugin-list="pluginList"
v-show="layoutState.settings.showDesignSettings"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showDesignSettings: true // 控制settings面板是否展示。目前只在数据源的全屏查看时为false

根据文档描述:PR #1219 导致 showDesignSettings 配置失效了,请修复。

@chilingling chilingling merged commit 2dbade3 into opentiny:develop May 15, 2025
2 checks passed
@SonyLeo SonyLeo deleted the fix/warnings branch August 24, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants